From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by mail.toke.dk (Postfix) with ESMTPS id 25E8BA41E6F for ; Fri, 1 Dec 2023 16:09:20 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=kmYDT9Zo Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-77d645c0e06so112311685a.3 for ; Fri, 01 Dec 2023 07:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701443356; x=1702048156; darn=xdp-project.net; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zLso2pmbW+pqec/n5hTLrdVINDT0pM+C03w8nh7HKns=; b=kmYDT9Zo8Ima1OYygkt6UQaGXAW9Us7CeLqGn1mVlZ2Re/pO5NUtbjDT0tKCzl7sgZ dpxXfYogzBYSPWRt7gsWG3VAEARO3Nknin2eVA1k+3ofdhtufWDPx9fEiHutpzbJwZhE UYZ1JJDwm2jqQQUy9UGuvPCHE9fvh7oNHHP15U8WNW+oISQeuAbrah4sBwi+757c71u4 No/g1IB/ywgmCM0qFaPacoALdtrGhNvjtQ24XqBM0Gi+tOdLTiLRogKJU144Bh9HgUAn aieHrkdtq9A3e6ozAjr5tAwJYaHHWIFPaQJ3vS9NsoSNW/3cd/RIZ/5NLMQvxvarX9uU BhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701443356; x=1702048156; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zLso2pmbW+pqec/n5hTLrdVINDT0pM+C03w8nh7HKns=; b=oN6nHJODD2I5JJl1CPHCICWye+dJrL0q6FIUFwZIXEKxFMmsIKwnXwYtnekk0eVOfw ovqnm09NZN8RKkNKs18stus9nwnopQgsYpj9UHwOAj+bitlZLcj8E+W06LQgky3RvsLk JG07Tj6GZjStcyg+tAKRIUi8oCzMOU5DZU23dqjFCpnzux2L6WRCwLxhoGGMhseF5N7R jT603JXYfrH5vxst9MAcI5tbbipX7V+tCWqPPaPMCzm6xCfDChH0AZ//oTt83/nrwgAW 9XA7xhGIV1U78gqQcQmV9Eb3hKbUEhRipFQV9+LPZSx6vOz0RYMOpom7K9D9f84r77QR M0Ag== X-Gm-Message-State: AOJu0YyYlJa4d3JhkJ720H/LkFujpTelJ+2TtRySg2QRZm4sHL+NcRGE bTbcNBrArM034SVUoeEtCWo= X-Google-Smtp-Source: AGHT+IH54DZX3epKyg6LRt2pdYZkL/+XeUYhSrEyKX4h3aISopJX9pTR0/tZhUxii4HdMqDmoQRtqg== X-Received: by 2002:ad4:4511:0:b0:67a:8ed9:c9f with SMTP id k17-20020ad44511000000b0067a8ed90c9fmr3811562qvu.48.1701443356450; Fri, 01 Dec 2023 07:09:16 -0800 (PST) Received: from localhost (114.66.194.35.bc.googleusercontent.com. [35.194.66.114]) by smtp.gmail.com with ESMTPSA id g12-20020a0caacc000000b0067a39a44ca5sm1106qvb.77.2023.12.01.07.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 07:09:15 -0800 (PST) Date: Fri, 01 Dec 2023 10:09:15 -0500 From: Willem de Bruijn To: "Song, Yoong Siang" , Jesper Dangaard Brouer , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , "Karlsson, Magnus" , "Fijalkowski, Maciej" , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Message-ID: <6569f71bad00d_138af5294d@willemb.c.googlers.com.notmuch> In-Reply-To: References: <20231201062421.1074768-1-yoong.siang.song@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: MCYYN2R33LCQHQ3MFA6JQC53XV33Y7EF X-Message-ID-Hash: MCYYN2R33LCQHQ3MFA6JQC53XV33Y7EF X-MailFrom: willemdebruijn.kernel@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "bpf@vger.kernel.org" , "xdp-hints@xdp-project.net" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Song, Yoong Siang wrote: > On Friday, December 1, 2023 6:46 PM, Jesper Dangaard Brouer wrote: > >On 12/1/23 07:24, Song Yoong Siang wrote: > >> This series expands XDP TX metadata framework to include ETF HW offload. > >> > >> Changes since v1: > >> - rename Time-Based Scheduling (TBS) to Earliest TxTime First (ETF) > >> - rename launch-time to txtime > >> > > > >I strongly disagree with this renaming (sorry to disagree with Willem). > > > >The i210 and i225 chips call this LaunchTime in their programmers > >datasheets, and even in the driver code[1]. > > > >Using this "txtime" name in the code is also confusing, because how can > >people reading the code know the difference between: > > - tmo_request_timestamp and tmo_request_txtime > > > > Hi Jesper and Willem, > > How about using "launch_time" for the flag/variable and > "Earliest TxTime First" for the description/comments? I don't particularly care which term we use, as long as we're consistent. Especially, don't keep introducing new synonyms. The fact that one happens to be one vendor's marketing term does not make it preferable, IMHO. On the contrary. SO_TXTIME is in the ABI, and EDT has been used publicly in kernel patches and conference talks, e.g., Van Jacobson's Netdev 0x12 keynote. Those are vendor agnostic commonly used terms. But as long as Launch Time is not an Intel only trademark, fine to select that.