From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail.toke.dk; spf=pass (mailfrom) smtp.mailfrom=linux.dev (client-ip=91.218.175.171; helo=out-171.mta0.migadu.com; envelope-from=martin.lau@linux.dev; receiver=<UNKNOWN>)
Authentication-Results: mail.toke.dk;
	dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=VpC0XOi/
Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171])
	by mail.toke.dk (Postfix) with ESMTPS id 3826C9E6431
	for <xdp-hints@xdp-project.net>; Wed,  1 Feb 2023 18:46:48 +0100 (CET)
Message-ID: <484ca75b-d5f0-31db-6f81-2fb17ce0702e@linux.dev>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1675273607;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=J+Zuzz/eG7rfVrQVnPkpNvhb87iYoOFZHxh0vAcr8AI=;
	b=VpC0XOi/C/dpXZ97CaNwz+7J40h7DqmoIj4xsb6MDRIHxb/E9iLSUV8lCXmWotAQj/tx3N
	U/wE60ZNTUYtIdWteYxdcieANAR8XQ1AFW3nLnAuyUi1cEKi5Bo2Ndjd3/JOw9QH3CwgUu
	vt4siNxvdDlSECwekKf8MnFQflAh5jc=
Date: Wed, 1 Feb 2023 09:46:36 -0800
MIME-Version: 1.0
Content-Language: en-US
To: Jesper Dangaard Brouer <brouer@redhat.com>,
 Stanislav Fomichev <sdf@google.com>
References: <167527267453.937063.6000918625343592629.stgit@firesoul>
 <167527271533.937063.5717065138099679142.stgit@firesoul>
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Martin KaFai Lau <martin.lau@linux.dev>
In-Reply-To: <167527271533.937063.5717065138099679142.stgit@firesoul>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Migadu-Flow: FLOW_OUT
Message-ID-Hash: VKGWLNV256JXUTQWQKD6AMRCKBTSLXCG
X-Message-ID-Hash: VKGWLNV256JXUTQWQKD6AMRCKBTSLXCG
X-MailFrom: martin.lau@linux.dev
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: netdev@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, dsahern@gmail.com, willemb@google.com, void@manifault.com, kuba@kernel.org, xdp-hints@xdp-project.net, bpf@vger.kernel.org
X-Mailman-Version: 3.3.8
Precedence: list
Subject: [xdp-hints] Re: [PATCH bpf-next V2 2/4] selftests/bpf: xdp_hw_metadata cleanup cause segfault
List-Id: XDP hardware hints design discussion <xdp-hints.xdp-project.net>
Archived-At: <https://lists.xdp-project.net/xdp-hints/484ca75b-d5f0-31db-6f81-2fb17ce0702e@linux.dev/>
List-Archive: <https://lists.xdp-project.net/xdp-hints/>
List-Help: <mailto:xdp-hints-request@xdp-project.net?subject=help>
List-Owner: <mailto:xdp-hints-owner@xdp-project.net>
List-Post: <mailto:xdp-hints@xdp-project.net>
List-Subscribe: <mailto:xdp-hints-join@xdp-project.net>
List-Unsubscribe: <mailto:xdp-hints-leave@xdp-project.net>

On 2/1/23 9:31 AM, Jesper Dangaard Brouer wrote:
> diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c
> index 3823b1c499cc..438083e34cce 100644
> --- a/tools/testing/selftests/bpf/xdp_hw_metadata.c
> +++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c
> @@ -121,7 +121,7 @@ static void close_xsk(struct xsk *xsk)
>   		xsk_umem__delete(xsk->umem);
>   	if (xsk->socket)
>   		xsk_socket__delete(xsk->socket);
> -	munmap(xsk->umem, UMEM_SIZE);
> +	munmap(xsk->umem_area, UMEM_SIZE);

Ah. Good catch. This should also explain a similar issue that CI is seeing in 
the prog_tests/xdp_metadata.c.