From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mail.toke.dk (Postfix) with ESMTPS id 8031499E886 for ; Fri, 9 Sep 2022 15:48:35 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OJDq9yKd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662731314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YImNobrFe/WhuWDTj42TmI0iV1ssLlERqxsuvNWDERI=; b=OJDq9yKdq7I7U3NdVH3sP1Pti7pNYtw/V/yK90sIJGNJxPAKgtBo19jFqRDy7KbElVDwbm ebv/duF8vnNIgUB6LLhqJySOLIPUdVS7JN+gCjlsm12qR15oJL66YmGAhHTE9u3MQ+fDBh M08hTBcEHU0cfu77asqIRl0iM6Uge4U= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-622-hZ5Elzc8OxijvFqLzGT7Jw-1; Fri, 09 Sep 2022 09:48:33 -0400 X-MC-Unique: hZ5Elzc8OxijvFqLzGT7Jw-1 Received: by mail-ed1-f71.google.com with SMTP id b16-20020a056402279000b0044f1102e6e2so1330185ede.20 for ; Fri, 09 Sep 2022 06:48:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=YImNobrFe/WhuWDTj42TmI0iV1ssLlERqxsuvNWDERI=; b=EFWsmk2IK/ZBKTfQ00FrYh9/2jNWo61LEv3nyV6Q49ZIcsF1o2+DOYc1spK94kY6iq PNSLPbQTV8kS46sn9shUyaP+VGRMnbFfjDUU1pzYNaqJtv/smoFqnVw+mTy8QISCDS23 huc6c2WuQp36myMRkXK7DDhMb5XS4Dwze9q0KgD2OjLAwczky+BYHg29c3wVMDoA20qy ANgYuMRiwH6u2GRP+wvo2Llg6vqvm0qV60FfZNR+LPNLHWGBBk99b74cLju4+anwCGWz VFtFzEM2LAEyKvtJps8W7WdACDRfUtQ+xzHadXWjHjXBHnsqVScWAlWVRgWUyZuDLpLz SpwA== X-Gm-Message-State: ACgBeo2JttSvaAQ8tiI+oLHxwTJYhruLgdZqAgC1iC9di3v9xWYXT9od up/Z/sbj8xEq2UhnU7D5swq4g3tVhePQc9BhLdHvNhnxU5s+lEazxYJZka+JqAZcOUzSb4jY3mH dyVH8+ajSNiE23zKtCRaD X-Received: by 2002:a05:6402:2786:b0:448:e15d:ab0e with SMTP id b6-20020a056402278600b00448e15dab0emr11602232ede.91.1662731311939; Fri, 09 Sep 2022 06:48:31 -0700 (PDT) X-Google-Smtp-Source: AA6agR6N5xVGmsWUYQGhRgZqvZxQk2yqsaCgbYWlCDEXeY7sJ7OUl4WVZyP0sxTnug/6kY7xRheOcA== X-Received: by 2002:a05:6402:2786:b0:448:e15d:ab0e with SMTP id b6-20020a056402278600b00448e15dab0emr11602201ede.91.1662731311724; Fri, 09 Sep 2022 06:48:31 -0700 (PDT) Received: from [192.168.41.81] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id kw4-20020a170907770400b0073dcdf9b0bcsm338050ejc.17.2022.09.09.06.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 06:48:31 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <434a45f6-aaf6-3bf0-8efe-c28a6c8b604d@redhat.com> Date: Fri, 9 Sep 2022 15:48:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: Alexander Lobakin References: <166256538687.1434226.15760041133601409770.stgit@firesoul> <20220908093043.274201-1-alexandr.lobakin@intel.com> In-Reply-To: <20220908093043.274201-1-alexandr.lobakin@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: B5PW5L4F5NYLSMGM4E6OJVRNQHL2LGTY X-Message-ID-Hash: B5PW5L4F5NYLSMGM4E6OJVRNQHL2LGTY X-MailFrom: jbrouer@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: brouer@redhat.com, bpf@vger.kernel.org, netdev@vger.kernel.org, xdp-hints@xdp-project.net, larysa.zaremba@intel.com, memxor@gmail.com, Lorenzo Bianconi , mtahhan@redhat.com, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , dave@dtucker.co.uk, Magnus Karlsson , bjorn@kernel.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [xdp-hints] Re: [PATCH RFCv2 bpf-next 00/18] XDP-hints: XDP gaining access to HW offload hints via BTF List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08/09/2022 11.30, Alexander Lobakin wrote: > From: Jesper Dangaard Brouer > Date: Wed, 07 Sep 2022 17:45:00 +0200 > >> This patchset expose the traditional hardware offload hints to XDP and >> rely on BTF to expose the layout to users. >> [...] >> The main different from RFC-v1: >> - Drop idea of BTF "origin" (vmlinux, module or local) >> - Instead to use full 64-bit BTF ID that combine object+type ID >> >> I've taken some of Alexandr/Larysa's libbpf patches and integrated >> those. > > Not sure if it's okay to inform the authors about the fact only > after sending? Esp from the eeeh... "incompatible" implementation? Just to be clear: I have made sure that developers of the patches maintain authorship (when applied to git via the From: line) and I've Cc'ed the developers directly. I didn't Cc you directly as I knew you would be included via XDP-hints list, and I didn't directly use one of your patches. > I realize it's open code, but this looks sorta depreciatingly. After discussions with Larysa on pre-patchset, I was convinced of the idea of a full 64-bit BTF ID. Thus, I took those patches and carried them in my patchset, instead of reimplementing the same myself. Precisely out of respect for Larysa's work as I wanted to give her credit for coding this. I'm very interested in collaborating. That is why I have picked up patches from your patchset and are carrying them forward. I could just as easily reimplemented them myself. --Jesper