From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Stanislav Fomichev <stfomichev@gmail.com>,
Florian Bezdeka <florian.bezdeka@siemens.com>,
"Song, Yoong Siang" <yoong.siang.song@intel.com>,
"Bouska, Zdenek" <zdenek.bouska@siemens.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jonathan Corbet <corbet@lwn.net>, Bjorn Topel <bjorn@kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"Damato, Joe" <jdamato@fastly.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Mina Almasry <almasrymina@google.com>,
Daniel Jurgens <danielj@nvidia.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"xdp-hints@xdp-project.net" <xdp-hints@xdp-project.net>
Subject: [xdp-hints] Re: [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC
Date: Mon, 27 Jan 2025 10:04:41 -0800 [thread overview]
Message-ID: <20250127100441.0b11e1b8@kernel.org> (raw)
In-Reply-To: <87bjvwqvtl.fsf@toke.dk>
On Fri, 24 Jan 2025 12:45:42 +0100 Toke Høiland-Jørgensen wrote:
> >> I think there is no simple fix for that. That needs some discussion
> >> around the "expectations" to the headroom / meta data area in front of
> >> the actual packet data.
> >
> > By 'simple' you mean without some new UAPI to signal the size of that
> > 'reserved area' by the driver? I don't see any other easy way out as well :-/
>
> Yeah, I don't think we can impose UAPI restrictions on the metadata area
> at this point. I guess the best we can do is to educate users that they
> should call the timestamp kfunc before they modify the metadata?
I may be misunderstanding the discussion, but I think the answer
is that the driver must be fixed. The metadata-in-prepend problem
also exists for simple adjust head use case, so it existed since
early days of BPF. The driver should copy out (or parse) the metadata
before it invokes the XDP prog. The nfp driver does that.
next prev parent reply other threads:[~2025-01-27 18:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 15:53 [xdp-hints] [PATCH bpf-next v6 0/4] xsk: TX metadata Launch Time support Song Yoong Siang
2025-01-16 15:53 ` [xdp-hints] [PATCH bpf-next v6 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata Song Yoong Siang
2025-01-16 15:53 ` [xdp-hints] [PATCH bpf-next v6 2/4] selftests/bpf: Add launch time request to xdp_hw_metadata Song Yoong Siang
2025-01-23 19:48 ` [xdp-hints] " Stanislav Fomichev
2025-01-16 15:53 ` [xdp-hints] [PATCH bpf-next v6 3/4] net: stmmac: Add launch time support to XDP ZC Song Yoong Siang
2025-01-16 15:53 ` [xdp-hints] [PATCH bpf-next v6 4/4] igc: " Song Yoong Siang
2025-01-20 6:25 ` [xdp-hints] " Abdul Rahim, Faizal
2025-01-20 7:24 ` Choong Yong Liang
2025-01-20 10:08 ` Song, Yoong Siang
2025-01-20 10:06 ` Song, Yoong Siang
2025-01-23 15:40 ` Bouska, Zdenek
2025-01-23 16:41 ` Song, Yoong Siang
2025-01-23 17:24 ` Florian Bezdeka
2025-01-23 19:49 ` Stanislav Fomichev
2025-01-24 11:45 ` Toke Høiland-Jørgensen
2025-01-27 18:04 ` Jakub Kicinski [this message]
2025-01-27 18:29 ` Florian Bezdeka
2025-01-27 19:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127100441.0b11e1b8@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=florian.bezdeka@siemens.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=mcoquelin.stm32@gmail.com \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=stfomichev@gmail.com \
--cc=toke@redhat.com \
--cc=willemb@google.com \
--cc=xdp-hints@xdp-project.net \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yonghong.song@linux.dev \
--cc=yoong.siang.song@intel.com \
--cc=zdenek.bouska@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox