From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by mail.toke.dk (Postfix) with ESMTPS id DFC1FA405FD for ; Mon, 27 Nov 2023 20:03:28 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=t3zt0A2I Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-6cb42be51easo5638394b3a.1 for ; Mon, 27 Nov 2023 11:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701111807; x=1701716607; darn=xdp-project.net; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=NZmbhowMLIPaXt1/O5qGG+PgL70lJmkQfw56CCK9VMM=; b=t3zt0A2IiIqVqwyjGIX9r1VrnrudvZHJxSHeNsqclNY2vVm4Tv3ZvFcCQ7NctgattK QUWnlxXDbVxXmAnrznBhgjFhAaRyKVB34I8NweL5kmxSpKN78TUR+TCRcoXeMUu0lt9K oIaC0Dw2nwKmRVCi6hMAcO1tdAe9NASEDM+/xhQBOqy5vrVNralC4b+AyEmtow2gp+Jb EycX5rndgDOvZxrQuwD0bdiriu2MsdRudS64oHZ4iODx0FfynBxAkK6OlWW9x/Ij9wvf fApOBc/axbagXH7Qr0Fhh7wA1YvJ6frzMCsiHdXPPloQI2wkPrpaubxXXMGjC5aI+pDZ Pq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701111807; x=1701716607; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NZmbhowMLIPaXt1/O5qGG+PgL70lJmkQfw56CCK9VMM=; b=efJDhc9IjmfIMHAv6T7B5i/jeebSSn2GbTMWPvuKge0WPakjyb9+ZCCPsspDQKi+5m oGaUDbefNE3iEdcxZUD9xA3I6DzYzavsCoKHOvOPDgYi8sZ3mLANs1fv6Bxv9/tVLYmK FKUhhkZ2qzvmaSbdG9gf55+cOpb4oZ4/6EBPHxHl3oSkPoHYIQDEL9SaVCJ3w/L/e9q3 BZ32mdSlBWRh7QQrSJX0Kd+v0peymFUnt7zws+pUTNB2iby6qmipSLwSfqkU5RUejlCy lZ01DBK5nk6Ziu6mXN14eUULVz/25IFpb5nKljS3eg7HVEDzWtNc6j3gMSiP8G9pczle GXCQ== X-Gm-Message-State: AOJu0YyOUb9pYSHkEq20vRtqqvHgmz/m9eE2K67vzXe/OJ2hCGbo1wnm POhpgvsQPeN2oeAAO6nOxXWCYwE= X-Google-Smtp-Source: AGHT+IFKylgGgz4FPHYQx7uLvq9IjNMDty/QvWbEOwBFCwVeAcMS9nY3gUMmOn56aiimoTypBJj+hDU= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a05:6a00:3a12:b0:692:c216:8830 with SMTP id fj18-20020a056a003a1200b00692c2168830mr3426229pfb.0.1701111806732; Mon, 27 Nov 2023 11:03:26 -0800 (PST) Date: Mon, 27 Nov 2023 11:03:09 -0800 In-Reply-To: <20231127190319.1190813-1-sdf@google.com> Mime-Version: 1.0 References: <20231127190319.1190813-1-sdf@google.com> X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Message-ID: <20231127190319.1190813-4-sdf@google.com> From: Stanislav Fomichev To: bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: 7SG2ZUTALJ3F4DEDZAS3RJIIWJD4OXN2 X-Message-ID-Hash: 7SG2ZUTALJ3F4DEDZAS3RJIIWJD4OXN2 X-MailFrom: 3_udkZQMKCZMF023BB381.zB9K0C-45AGFK0C-CEB61zG.A1G@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, kuba@kernel.org, toke@kernel.org, willemb@google.com, dsahern@kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, maciej.fijalkowski@intel.com, hawk@kernel.org, yoong.siang.song@intel.com, netdev@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] [PATCH bpf-next v6 03/13] tools: ynl: Print xsk-features from the sample List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In a similar fashion we do for the other bit masks. Fix mask parsing (>= vs >) while we are it. Signed-off-by: Stanislav Fomichev --- tools/net/ynl/samples/netdev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/net/ynl/samples/netdev.c b/tools/net/ynl/samples/netdev.c index b828225daad0..591b90e21890 100644 --- a/tools/net/ynl/samples/netdev.c +++ b/tools/net/ynl/samples/netdev.c @@ -33,17 +33,23 @@ static void netdev_print_device(struct netdev_dev_get_rsp *d, unsigned int op) return; printf("xdp-features (%llx):", d->xdp_features); - for (int i = 0; d->xdp_features > 1U << i; i++) { + for (int i = 0; d->xdp_features >= 1U << i; i++) { if (d->xdp_features & (1U << i)) printf(" %s", netdev_xdp_act_str(1 << i)); } printf(" xdp-rx-metadata-features (%llx):", d->xdp_rx_metadata_features); - for (int i = 0; d->xdp_rx_metadata_features > 1U << i; i++) { + for (int i = 0; d->xdp_rx_metadata_features >= 1U << i; i++) { if (d->xdp_rx_metadata_features & (1U << i)) printf(" %s", netdev_xdp_rx_metadata_str(1 << i)); } + printf(" xsk-features (%llx):", d->xsk_features); + for (int i = 0; d->xsk_features >= 1U << i; i++) { + if (d->xsk_features & (1U << i)) + printf(" %s", netdev_xsk_flags_str(1 << i)); + } + printf(" xdp-zc-max-segs=%u", d->xdp_zc_max_segs); name = netdev_op_str(op); -- 2.43.0.rc1.413.gea7ed67945-goog