XDP hardware hints discussion mail archive
 help / color / mirror / Atom feed
From: Larysa Zaremba <larysa.zaremba@intel.com>
To: bpf@vger.kernel.org
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
	john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
	haoluo@google.com, jolsa@kernel.org,
	David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Alexander Lobakin <alexandr.lobakin@intel.com>,
	Magnus Karlsson <magnus.karlsson@gmail.com>,
	Maryam Tahhan <mtahhan@redhat.com>,
	xdp-hints@xdp-project.net, netdev@vger.kernel.org,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: [xdp-hints] [PATCH bpf-next v7 12/18] veth: Implement VLAN tag XDP hint
Date: Wed, 15 Nov 2023 18:52:54 +0100	[thread overview]
Message-ID: <20231115175301.534113-13-larysa.zaremba@intel.com> (raw)
In-Reply-To: <20231115175301.534113-1-larysa.zaremba@intel.com>

In order to test VLAN tag hint in hardware-independent selftests, implement
newly added hint in veth driver.

Acked-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
 drivers/net/veth.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 9980517ed8b0..b6617784e7d3 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1743,6 +1743,24 @@ static int veth_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash,
 	return 0;
 }
 
+static int veth_xdp_rx_vlan_tag(const struct xdp_md *ctx, __be16 *vlan_proto,
+				u16 *vlan_tci)
+{
+	const struct veth_xdp_buff *_ctx = (void *)ctx;
+	const struct sk_buff *skb = _ctx->skb;
+	int err;
+
+	if (!skb)
+		return -ENODATA;
+
+	err = __vlan_hwaccel_get_tag(skb, vlan_tci);
+	if (err)
+		return err;
+
+	*vlan_proto = skb->vlan_proto;
+	return err;
+}
+
 static const struct net_device_ops veth_netdev_ops = {
 	.ndo_init            = veth_dev_init,
 	.ndo_open            = veth_open,
@@ -1767,6 +1785,7 @@ static const struct net_device_ops veth_netdev_ops = {
 static const struct xdp_metadata_ops veth_xdp_metadata_ops = {
 	.xmo_rx_timestamp		= veth_xdp_rx_timestamp,
 	.xmo_rx_hash			= veth_xdp_rx_hash,
+	.xmo_rx_vlan_tag		= veth_xdp_rx_vlan_tag,
 };
 
 #define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HW_CSUM | \
-- 
2.41.0


  parent reply	other threads:[~2023-11-15 17:55 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 17:52 [xdp-hints] [PATCH bpf-next v7 00/18] XDP metadata via kfuncs for ice + VLAN hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 01/18] ice: make RX hash reading code more reusable Larysa Zaremba
2023-11-16 15:04   ` [xdp-hints] " Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 02/18] ice: make RX HW timestamp " Larysa Zaremba
2023-11-16 15:19   ` [xdp-hints] " Maciej Fijalkowski
2023-11-17 14:26     ` Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 03/18] ice: Make ptype internal to descriptor info processing Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 04/18] ice: Introduce ice_xdp_buff Larysa Zaremba
2023-11-16 12:52   ` [xdp-hints] " Maciej Fijalkowski
2023-11-16  2:55     ` Larysa Zaremba
2023-12-01 13:51       ` Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 05/18] ice: Support HW timestamp hint Larysa Zaremba
2023-11-16 15:21   ` [xdp-hints] " Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 06/18] ice: Support RX hash XDP hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 07/18] xsk: add functions to fill control buffer Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 08/18] ice: Support XDP hints in AF_XDP ZC mode Larysa Zaremba
2023-11-16 12:49   ` [xdp-hints] " Maciej Fijalkowski
2023-11-16  3:01     ` Larysa Zaremba
2023-11-16 15:01       ` Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 09/18] xdp: Add VLAN tag hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 10/18] ice: Implement " Larysa Zaremba
2023-11-16 15:47   ` [xdp-hints] " Maciej Fijalkowski
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 11/18] ice: use VLAN proto from ring packet context in skb path Larysa Zaremba
2023-11-17  8:10   ` [xdp-hints] " Maciej Fijalkowski
2023-11-17 14:07     ` Larysa Zaremba
2023-11-17 15:14       ` Maciej Fijalkowski
2023-11-15 17:52 ` Larysa Zaremba [this message]
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 13/18] net: make vlan_get_tag() return -ENODATA instead of -EINVAL Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 14/18] mlx5: implement VLAN tag XDP hint Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 15/18] selftests/bpf: Allow VLAN packets in xdp_hw_metadata Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 16/18] selftests/bpf: Add flags and VLAN hint to xdp_hw_metadata Larysa Zaremba
2023-11-15 17:52 ` [xdp-hints] [PATCH bpf-next v7 17/18] selftests/bpf: Use AF_INET for TX in xdp_metadata Larysa Zaremba
2023-11-20 21:15   ` [xdp-hints] " Stanislav Fomichev
     [not found]   ` <170051500599.3770946.2674696540245347885@gauss.local>
2023-11-21  9:02     ` Larysa Zaremba
2023-11-15 17:53 ` [xdp-hints] [PATCH bpf-next v7 18/18] selftests/bpf: Check VLAN tag and proto " Larysa Zaremba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231115175301.534113-13-larysa.zaremba@intel.com \
    --to=larysa.zaremba@intel.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=haoluo@google.com \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=mtahhan@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=tariqt@mellanox.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xdp-hints@xdp-project.net \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox