From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by mail.toke.dk (Postfix) with ESMTPS id F289EA2E0E0 for ; Tue, 3 Oct 2023 14:35:30 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bH0Pig52 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 31B35611BF; Tue, 3 Oct 2023 12:35:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90C2FC433C8; Tue, 3 Oct 2023 12:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696336528; bh=KkLfUgocu5F7KXQSvfrqaGnYcZzRw7HrYorKPZvmsys=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bH0Pig52T8oRLymG0RJ4ZctqFLc/nxKMDQmTHKn/nBAsNqWPISeavAJ5YAaVilzLU PJ3e9QZU1xMBFKoA8+ql/toVTTKh+ODqQUmxnTCr4goGcjiSASfkwigJAybBki1AoS QPuLw3HVZXN8wBe2WZ7qHgmzAHTgZ5GQ/+64MKT8MoJnZajInQgsKKZuy/GuwnUVYn lLv5KHivK8B2u2tPuJbfcn52HE2DTKGPWRHXb5EOVtBxd8DQ0yQwcKOLRHMNlZKbxx Zq05vH9sZhN4vE8z524HuCH85ZrB+KgNi0BkSoiSBTJV7qTSuyq9OY/6QSGPDy5vJ+ E66T5RD7HUwrQ== Date: Tue, 3 Oct 2023 05:35:19 -0700 From: Jakub Kicinski To: Larysa Zaremba Message-ID: <20231003053519.74ae8938@kernel.org> In-Reply-To: <20230927075124.23941-10-larysa.zaremba@intel.com> References: <20230927075124.23941-1-larysa.zaremba@intel.com> <20230927075124.23941-10-larysa.zaremba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OWCWUSC52WTBQPERYO45NLI7OHKREPE4 X-Message-ID-Hash: OWCWUSC52WTBQPERYO45NLI7OHKREPE4 X-MailFrom: kuba@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, David Ahern , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, Willem de Bruijn , Alexei Starovoitov , Simon Horman , Tariq Toukan , Saeed Mahameed , Maciej Fijalkowski X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [RFC bpf-next v2 09/24] xdp: Add VLAN tag hint List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 27 Sep 2023 09:51:09 +0200 Larysa Zaremba wrote: > Implement functionality that enables drivers to expose VLAN tag > to XDP code. > > VLAN tag is represented by 2 variables: > - protocol ID, which is passed to bpf code in BE > - VLAN TCI, in host byte order Sorry for a random chime-in but was there any discussion about the validity of VLAN stripping as an offload? I always thought this is a legacy "Windows" thing which allowed Windows drivers to operate on VLAN-tagged networks even before the OS itself understood VLANs... Do people actually care about having it enabled?