XDP hardware hints discussion mail archive
 help / color / mirror / Atom feed
From: Larysa Zaremba <larysa.zaremba@intel.com>
To: bpf@vger.kernel.org
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
	john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
	haoluo@google.com, jolsa@kernel.org,
	David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Alexander Lobakin <alexandr.lobakin@intel.com>,
	Magnus Karlsson <magnus.karlsson@gmail.com>,
	Maryam Tahhan <mtahhan@redhat.com>,
	xdp-hints@xdp-project.net, netdev@vger.kernel.org,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Simon Horman <simon.horman@corigine.com>
Subject: [xdp-hints] [PATCH bpf-next v5 14/21] selftests/bpf: Allow VLAN packets in xdp_hw_metadata
Date: Fri, 11 Aug 2023 18:15:02 +0200	[thread overview]
Message-ID: <20230811161509.19722-15-larysa.zaremba@intel.com> (raw)
In-Reply-To: <20230811161509.19722-1-larysa.zaremba@intel.com>

Make VLAN c-tag and s-tag XDP hint testing more convenient
by not skipping VLAN-ed packets.

Allow both 802.1ad and 802.1Q headers.

Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
 tools/testing/selftests/bpf/progs/xdp_hw_metadata.c | 10 +++++++++-
 tools/testing/selftests/bpf/xdp_metadata.h          |  8 ++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
index b2dfd7066c6e..63d7de6c6bbb 100644
--- a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
+++ b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
@@ -26,15 +26,23 @@ int rx(struct xdp_md *ctx)
 {
 	void *data, *data_meta, *data_end;
 	struct ipv6hdr *ip6h = NULL;
-	struct ethhdr *eth = NULL;
 	struct udphdr *udp = NULL;
 	struct iphdr *iph = NULL;
 	struct xdp_meta *meta;
+	struct ethhdr *eth;
 	int err;
 
 	data = (void *)(long)ctx->data;
 	data_end = (void *)(long)ctx->data_end;
 	eth = data;
+
+	if (eth + 1 < data_end && (eth->h_proto == bpf_htons(ETH_P_8021AD) ||
+				   eth->h_proto == bpf_htons(ETH_P_8021Q)))
+		eth = (void *)eth + sizeof(struct vlan_hdr);
+
+	if (eth + 1 < data_end && eth->h_proto == bpf_htons(ETH_P_8021Q))
+		eth = (void *)eth + sizeof(struct vlan_hdr);
+
 	if (eth + 1 < data_end) {
 		if (eth->h_proto == bpf_htons(ETH_P_IP)) {
 			iph = (void *)(eth + 1);
diff --git a/tools/testing/selftests/bpf/xdp_metadata.h b/tools/testing/selftests/bpf/xdp_metadata.h
index 938a729bd307..6664893c2c77 100644
--- a/tools/testing/selftests/bpf/xdp_metadata.h
+++ b/tools/testing/selftests/bpf/xdp_metadata.h
@@ -9,6 +9,14 @@
 #define ETH_P_IPV6 0x86DD
 #endif
 
+#ifndef ETH_P_8021Q
+#define ETH_P_8021Q 0x8100
+#endif
+
+#ifndef ETH_P_8021AD
+#define ETH_P_8021AD 0x88A8
+#endif
+
 struct xdp_meta {
 	__u64 rx_timestamp;
 	__u64 xdp_timestamp;
-- 
2.41.0


  parent reply	other threads:[~2023-08-11 16:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 16:14 [xdp-hints] [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 01/21] ice: make RX hash reading code more reusable Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 02/21] ice: make RX HW timestamp " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 03/21] ice: make RX checksum checking " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 04/21] ice: Make ptype internal to descriptor info processing Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 05/21] ice: Introduce ice_xdp_buff Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 06/21] ice: Support HW timestamp hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 07/21] ice: Support RX hash XDP hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 08/21] ice: Support XDP hints in AF_XDP ZC mode Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 09/21] xdp: Add VLAN tag hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 10/21] ice: Implement " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 11/21] ice: use VLAN proto from ring packet context in skb path Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 12/21] xdp: Add checksum hint Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 13/21] ice: Implement " Larysa Zaremba
2023-08-17 21:58   ` [xdp-hints] " Alexei Starovoitov
2023-08-22  9:07     ` Larysa Zaremba
2023-08-22 19:50       ` Alexei Starovoitov
2023-08-11 16:15 ` Larysa Zaremba [this message]
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 15/21] net, xdp: allow metadata > 32 Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 16/21] selftests/bpf: Add flags and new hints to xdp_hw_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 17/21] veth: Implement VLAN tag and checksum XDP hint Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 18/21] net: make vlan_get_tag() return -ENODATA instead of -EINVAL Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 19/21] selftests/bpf: Use AF_INET for TX in xdp_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 20/21] selftests/bpf: Check VLAN tag and proto " Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 21/21] selftests/bpf: check checksum state " Larysa Zaremba
2023-08-11 16:23 ` [xdp-hints] Re: [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice Larysa Zaremba
2023-08-15 18:45 ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230811161509.19722-15-larysa.zaremba@intel.com \
    --to=larysa.zaremba@intel.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=magnus.karlsson@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=mtahhan@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@google.com \
    --cc=simon.horman@corigine.com \
    --cc=song@kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=xdp-hints@xdp-project.net \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox