From: Larysa Zaremba <larysa.zaremba@intel.com>
To: bpf@vger.kernel.org
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Maryam Tahhan <mtahhan@redhat.com>,
xdp-hints@xdp-project.net, netdev@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Simon Horman <simon.horman@corigine.com>
Subject: [xdp-hints] [PATCH bpf-next v5 12/21] xdp: Add checksum hint
Date: Fri, 11 Aug 2023 18:15:00 +0200 [thread overview]
Message-ID: <20230811161509.19722-13-larysa.zaremba@intel.com> (raw)
In-Reply-To: <20230811161509.19722-1-larysa.zaremba@intel.com>
Implement functionality that enables drivers to expose to XDP code checksum
information that consists of:
- Checksum status - 2 non-exlusive flags:
- XDP_CHECKSUM_VERIFIED indicating HW has validated the checksum
(corresponding to CHECKSUM_UNNECESSARY in sk_buff)
- XDP_CHECKSUM_COMPLETE signifies the validity of the second argument
(corresponding to CHECKSUM_COMPLETE in sk_buff)
- Checksum, calculated over the entire packet, valid if the second flag is
set
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
Documentation/networking/xdp-rx-metadata.rst | 3 +++
include/net/xdp.h | 15 +++++++++++++
kernel/bpf/offload.c | 2 ++
net/core/xdp.c | 23 ++++++++++++++++++++
4 files changed, 43 insertions(+)
diff --git a/Documentation/networking/xdp-rx-metadata.rst b/Documentation/networking/xdp-rx-metadata.rst
index ea6dd79a21d3..7f056a44f682 100644
--- a/Documentation/networking/xdp-rx-metadata.rst
+++ b/Documentation/networking/xdp-rx-metadata.rst
@@ -26,6 +26,9 @@ metadata is supported, this set will grow:
.. kernel-doc:: net/core/xdp.c
:identifiers: bpf_xdp_metadata_rx_vlan_tag
+.. kernel-doc:: net/core/xdp.c
+ :identifiers: bpf_xdp_metadata_rx_csum
+
An XDP program can use these kfuncs to read the metadata into stack
variables for its own consumption. Or, to pass the metadata on to other
consumers, an XDP program can store it into the metadata area carried
diff --git a/include/net/xdp.h b/include/net/xdp.h
index 8bb64fc76498..495c4d2a2c50 100644
--- a/include/net/xdp.h
+++ b/include/net/xdp.h
@@ -390,6 +390,8 @@ void xdp_attachment_setup(struct xdp_attachment_info *info,
bpf_xdp_metadata_rx_hash) \
XDP_METADATA_KFUNC(XDP_METADATA_KFUNC_RX_VLAN_TAG, \
bpf_xdp_metadata_rx_vlan_tag) \
+ XDP_METADATA_KFUNC(XDP_METADATA_KFUNC_RX_CSUM, \
+ bpf_xdp_metadata_rx_csum) \
enum {
#define XDP_METADATA_KFUNC(name, _) name,
@@ -447,12 +449,25 @@ enum xdp_rss_hash_type {
XDP_RSS_TYPE_L4_IPV6_SCTP_EX = XDP_RSS_TYPE_L4_IPV6_SCTP | XDP_RSS_L3_DYNHDR,
};
+enum xdp_csum_status {
+ /* HW had parsed headers and validated the outermost checksum,
+ * same as ``CHECKSUM_UNNECESSARY`` in ``sk_buff``.
+ */
+ XDP_CHECKSUM_VERIFIED = BIT(0),
+
+ /* Checksum, calculated over the entire packet is provided */
+ XDP_CHECKSUM_COMPLETE = BIT(1),
+};
+
struct xdp_metadata_ops {
int (*xmo_rx_timestamp)(const struct xdp_md *ctx, u64 *timestamp);
int (*xmo_rx_hash)(const struct xdp_md *ctx, u32 *hash,
enum xdp_rss_hash_type *rss_type);
int (*xmo_rx_vlan_tag)(const struct xdp_md *ctx, u16 *vlan_tci,
__be16 *vlan_proto);
+ int (*xmo_rx_csum)(const struct xdp_md *ctx,
+ enum xdp_csum_status *csum_status,
+ __wsum *csum);
};
#ifdef CONFIG_NET
diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
index 8be340cf06f9..ee35f33a96d1 100644
--- a/kernel/bpf/offload.c
+++ b/kernel/bpf/offload.c
@@ -851,6 +851,8 @@ void *bpf_dev_bound_resolve_kfunc(struct bpf_prog *prog, u32 func_id)
p = ops->xmo_rx_hash;
else if (func_id == bpf_xdp_metadata_kfunc_id(XDP_METADATA_KFUNC_RX_VLAN_TAG))
p = ops->xmo_rx_vlan_tag;
+ else if (func_id == bpf_xdp_metadata_kfunc_id(XDP_METADATA_KFUNC_RX_CSUM))
+ p = ops->xmo_rx_csum;
out:
up_read(&bpf_devs_lock);
diff --git a/net/core/xdp.c b/net/core/xdp.c
index 856e02bb4ce6..b197287d7196 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -772,6 +772,29 @@ __bpf_kfunc int bpf_xdp_metadata_rx_vlan_tag(const struct xdp_md *ctx,
return -EOPNOTSUPP;
}
+/**
+ * bpf_xdp_metadata_rx_csum - Get checksum status with additional info.
+ * @ctx: XDP context pointer.
+ * @csum_status: Destination for checksum status.
+ * @csum: Destination for complete checksum.
+ *
+ * Status (@csum_status) is a bitfield that informs, what checksum
+ * processing was performed. If ``XDP_CHECKSUM_COMPLETE`` in status is set,
+ * second argument (@csum) contains a checksum, calculated over the entire
+ * packet.
+ *
+ * Return:
+ * * Returns 0 on success or ``-errno`` on error.
+ * * ``-EOPNOTSUPP`` : device driver doesn't implement kfunc
+ * * ``-ENODATA`` : Checksum status is unknown
+ */
+__bpf_kfunc int bpf_xdp_metadata_rx_csum(const struct xdp_md *ctx,
+ enum xdp_csum_status *csum_status,
+ __wsum *csum)
+{
+ return -EOPNOTSUPP;
+}
+
__diag_pop();
BTF_SET8_START(xdp_metadata_kfunc_ids)
--
2.41.0
next prev parent reply other threads:[~2023-08-11 16:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 16:14 [xdp-hints] [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 01/21] ice: make RX hash reading code more reusable Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 02/21] ice: make RX HW timestamp " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 03/21] ice: make RX checksum checking " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 04/21] ice: Make ptype internal to descriptor info processing Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 05/21] ice: Introduce ice_xdp_buff Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 06/21] ice: Support HW timestamp hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 07/21] ice: Support RX hash XDP hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 08/21] ice: Support XDP hints in AF_XDP ZC mode Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 09/21] xdp: Add VLAN tag hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 10/21] ice: Implement " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 11/21] ice: use VLAN proto from ring packet context in skb path Larysa Zaremba
2023-08-11 16:15 ` Larysa Zaremba [this message]
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 13/21] ice: Implement checksum hint Larysa Zaremba
2023-08-17 21:58 ` [xdp-hints] " Alexei Starovoitov
2023-08-22 9:07 ` Larysa Zaremba
2023-08-22 19:50 ` Alexei Starovoitov
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 14/21] selftests/bpf: Allow VLAN packets in xdp_hw_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 15/21] net, xdp: allow metadata > 32 Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 16/21] selftests/bpf: Add flags and new hints to xdp_hw_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 17/21] veth: Implement VLAN tag and checksum XDP hint Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 18/21] net: make vlan_get_tag() return -ENODATA instead of -EINVAL Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 19/21] selftests/bpf: Use AF_INET for TX in xdp_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 20/21] selftests/bpf: Check VLAN tag and proto " Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 21/21] selftests/bpf: check checksum state " Larysa Zaremba
2023-08-11 16:23 ` [xdp-hints] Re: [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice Larysa Zaremba
2023-08-15 18:45 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811161509.19722-13-larysa.zaremba@intel.com \
--to=larysa.zaremba@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mtahhan@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=simon.horman@corigine.com \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xdp-hints@xdp-project.net \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox