From: Larysa Zaremba <larysa.zaremba@intel.com>
To: bpf@vger.kernel.org
Cc: Larysa Zaremba <larysa.zaremba@intel.com>,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org,
David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Maryam Tahhan <mtahhan@redhat.com>,
xdp-hints@xdp-project.net, netdev@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Simon Horman <simon.horman@corigine.com>
Subject: [xdp-hints] [PATCH bpf-next v5 11/21] ice: use VLAN proto from ring packet context in skb path
Date: Fri, 11 Aug 2023 18:14:59 +0200 [thread overview]
Message-ID: <20230811161509.19722-12-larysa.zaremba@intel.com> (raw)
In-Reply-To: <20230811161509.19722-1-larysa.zaremba@intel.com>
VLAN proto, used in ice XDP hints implementation is stored in ring packet
context. Utilize this value in skb VLAN processing too instead of checking
netdev features.
At the same time, use vlan_tci instead of vlan_tag in touched code,
because vlan_tag is misleading.
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
---
drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 14 +++++---------
drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 10e7ec51f4ef..6ae57a98a4d8 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
@@ -283,21 +283,17 @@ ice_process_skb_fields(struct ice_rx_ring *rx_ring,
* ice_receive_skb - Send a completed packet up the stack
* @rx_ring: Rx ring in play
* @skb: packet to send up
- * @vlan_tag: VLAN tag for packet
+ * @vlan_tci: VLAN TCI for packet
*
* This function sends the completed packet (via. skb) up the stack using
* gro receive functions (with/without VLAN tag)
*/
void
-ice_receive_skb(struct ice_rx_ring *rx_ring, struct sk_buff *skb, u16 vlan_tag)
+ice_receive_skb(struct ice_rx_ring *rx_ring, struct sk_buff *skb, u16 vlan_tci)
{
- netdev_features_t features = rx_ring->netdev->features;
- bool non_zero_vlan = !!(vlan_tag & VLAN_VID_MASK);
-
- if ((features & NETIF_F_HW_VLAN_CTAG_RX) && non_zero_vlan)
- __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
- else if ((features & NETIF_F_HW_VLAN_STAG_RX) && non_zero_vlan)
- __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021AD), vlan_tag);
+ if (vlan_tci & VLAN_VID_MASK && rx_ring->pkt_ctx.vlan_proto)
+ __vlan_hwaccel_put_tag(skb, rx_ring->pkt_ctx.vlan_proto,
+ vlan_tci);
napi_gro_receive(&rx_ring->q_vector->napi, skb);
}
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.h b/drivers/net/ethernet/intel/ice/ice_txrx_lib.h
index b7205826fea8..8487884bf5c4 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.h
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.h
@@ -150,7 +150,7 @@ ice_process_skb_fields(struct ice_rx_ring *rx_ring,
union ice_32b_rx_flex_desc *rx_desc,
struct sk_buff *skb);
void
-ice_receive_skb(struct ice_rx_ring *rx_ring, struct sk_buff *skb, u16 vlan_tag);
+ice_receive_skb(struct ice_rx_ring *rx_ring, struct sk_buff *skb, u16 vlan_tci);
static inline void
ice_xdp_meta_set_desc(struct xdp_buff *xdp,
--
2.41.0
next prev parent reply other threads:[~2023-08-11 16:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 16:14 [xdp-hints] [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 01/21] ice: make RX hash reading code more reusable Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 02/21] ice: make RX HW timestamp " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 03/21] ice: make RX checksum checking " Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 04/21] ice: Make ptype internal to descriptor info processing Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 05/21] ice: Introduce ice_xdp_buff Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 06/21] ice: Support HW timestamp hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 07/21] ice: Support RX hash XDP hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 08/21] ice: Support XDP hints in AF_XDP ZC mode Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 09/21] xdp: Add VLAN tag hint Larysa Zaremba
2023-08-11 16:14 ` [xdp-hints] [PATCH bpf-next v5 10/21] ice: Implement " Larysa Zaremba
2023-08-11 16:14 ` Larysa Zaremba [this message]
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 12/21] xdp: Add checksum hint Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 13/21] ice: Implement " Larysa Zaremba
2023-08-17 21:58 ` [xdp-hints] " Alexei Starovoitov
2023-08-22 9:07 ` Larysa Zaremba
2023-08-22 19:50 ` Alexei Starovoitov
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 14/21] selftests/bpf: Allow VLAN packets in xdp_hw_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 15/21] net, xdp: allow metadata > 32 Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 16/21] selftests/bpf: Add flags and new hints to xdp_hw_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 17/21] veth: Implement VLAN tag and checksum XDP hint Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 18/21] net: make vlan_get_tag() return -ENODATA instead of -EINVAL Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 19/21] selftests/bpf: Use AF_INET for TX in xdp_metadata Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 20/21] selftests/bpf: Check VLAN tag and proto " Larysa Zaremba
2023-08-11 16:15 ` [xdp-hints] [PATCH bpf-next v5 21/21] selftests/bpf: check checksum state " Larysa Zaremba
2023-08-11 16:23 ` [xdp-hints] Re: [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice Larysa Zaremba
2023-08-15 18:45 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811161509.19722-12-larysa.zaremba@intel.com \
--to=larysa.zaremba@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@gmail.com \
--cc=martin.lau@linux.dev \
--cc=mtahhan@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=simon.horman@corigine.com \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xdp-hints@xdp-project.net \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox