From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mail.toke.dk (Postfix) with ESMTPS id 65240A207C1 for ; Fri, 11 Aug 2023 18:20:20 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=iUQqKz1Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691770821; x=1723306821; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ig8Rsyw6R9Hqmc8W6Jm8TKLVYM7OHcEFUQj1E4PPqDE=; b=iUQqKz1QWVrvHP9qD9ZAi4Rl6aX89ARncn3MNa0x2YzVc5zlm6h4sdXL p2HO6ZCADAHQIVsxp7df+1AXN+SRFRl24l5nub3hV5k9wdhrU5Hu8vpZQ ic32Q6gdPE3FhOBcqGlnlUVQEpp15JjvNl96DnBBxiaKNwlsRgosCAbvb T1nlUf0cbQmUhp8Kop00bj8R33FODNrkOn1pc9L7pZTFAPrPxiQIXxvGv qYwfRVd+egmhjHsQf3uMYAT2LN9eiwtpDM8gcQ4i59AqbQnb0u9d+CnJ2 lzLw4He9RCf4lee+dL4yUjOW8zdSh7UdAbQ8S9uxQJhnZ3WR4lMzHg9WX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10799"; a="351314291" X-IronPort-AV: E=Sophos;i="6.01,166,1684825200"; d="scan'208";a="351314291" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2023 09:20:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10799"; a="906500929" X-IronPort-AV: E=Sophos;i="6.01,166,1684825200"; d="scan'208";a="906500929" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orsmga005.jf.intel.com with ESMTP; 11 Aug 2023 09:19:55 -0700 Received: from lincoln.igk.intel.com (lincoln.igk.intel.com [10.102.21.235]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 9ECC9332A0; Fri, 11 Aug 2023 17:19:53 +0100 (IST) From: Larysa Zaremba To: bpf@vger.kernel.org Date: Fri, 11 Aug 2023 18:14:48 +0200 Message-ID: <20230811161509.19722-1-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: KGUZQWWJUU6ISR374X4JIBXPEFVVN27A X-Message-ID-Hash: KGUZQWWJUU6ISR374X4JIBXPEFVVN27A X-MailFrom: larysa.zaremba@intel.com X-Mailman-Rule-Hits: member-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address CC: Larysa Zaremba , ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org, Willem de Bruijn , Alexei Starovoitov , Simon Horman X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This series introduces XDP hints via kfuncs [0] to the ice driver. Series brings the following existing hints to the ice driver: - HW timestamp - RX hash with type Series also introduces new hints and adds their implementation to ice and veth: - VLAN tag with protocol - Checksum status The data above can now be accessed by XDP and userspace (AF_XDP) programs. They can also be checked with xdp_metadata test and xdp_hw_metadata program. [0] https://patchwork.kernel.org/project/netdevbpf/cover/20230119221536.3349901-1-sdf@google.com/ v4: https://lore.kernel.org/bpf/20230728173923.1318596-1-larysa.zaremba@intel.com/ v3: https://lore.kernel.org/bpf/20230719183734.21681-1-larysa.zaremba@intel.com/ v2: https://lore.kernel.org/bpf/20230703181226.19380-1-larysa.zaremba@intel.com/ v1: https://lore.kernel.org/all/20230512152607.992209-1-larysa.zaremba@intel.com/ Changes since v4: - Drop the concept of partial checksum from the hint design - Drop the concept of checksum level from the hint design Changes since v3: - use XDP_CHECKSUM_VALID_LVL0 + csum_level instead of csum_level + 1 - fix spelling mistakes - read XDP timestamp unconditionally - add TO_STR() macro Changes since v2: - redesign checksum hint, so now it gives full status - rename vlan_tag -> vlan_tci, where applicable - use open_netns() and close_netns() in xdp_metadata - improve VLAN hint documentation - replace CFI with DEI - use VLAN_VID_MASK in xdp_metadata - make vlan_get_tag() return -ENODATA - remove unused rx_ptype in ice_xsk.c - fix ice timestamp code division between patches Changes since v1: - directly return RX hash, RX timestamp and RX checksum status in skb-common functions - use intermediate enum value for checksum status in ice - get rid of ring structure dependency in ice kfunc implementation - make variables const, when possible, in ice implementation - use -ENODATA instead of -EOPNOTSUPP for driver implementation - instead of having 2 separate functions for c-tag and s-tag, use 1 function that outputs both VLAN tag and protocol ID - improve documentation for introduced hints - update xdp_metadata selftest to test new hints - implement new hints in veth, so they can be tested in xdp_metadata - parse VLAN tag in xdp_hw_metadata Aleksander Lobakin (1): net, xdp: allow metadata > 32 Larysa Zaremba (20): ice: make RX hash reading code more reusable ice: make RX HW timestamp reading code more reusable ice: make RX checksum checking code more reusable ice: Make ptype internal to descriptor info processing ice: Introduce ice_xdp_buff ice: Support HW timestamp hint ice: Support RX hash XDP hint ice: Support XDP hints in AF_XDP ZC mode xdp: Add VLAN tag hint ice: Implement VLAN tag hint ice: use VLAN proto from ring packet context in skb path xdp: Add checksum hint ice: Implement checksum hint selftests/bpf: Allow VLAN packets in xdp_hw_metadata selftests/bpf: Add flags and new hints to xdp_hw_metadata veth: Implement VLAN tag and checksum XDP hint net: make vlan_get_tag() return -ENODATA instead of -EINVAL selftests/bpf: Use AF_INET for TX in xdp_metadata selftests/bpf: Check VLAN tag and proto in xdp_metadata selftests/bpf: check checksum state in xdp_metadata Documentation/networking/xdp-rx-metadata.rst | 11 +- drivers/net/ethernet/intel/ice/ice.h | 2 + drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +- .../net/ethernet/intel/ice/ice_lan_tx_rx.h | 412 +++++++++--------- drivers/net/ethernet/intel/ice/ice_lib.c | 2 +- drivers/net/ethernet/intel/ice/ice_main.c | 23 + drivers/net/ethernet/intel/ice/ice_ptp.c | 27 +- drivers/net/ethernet/intel/ice/ice_ptp.h | 15 +- drivers/net/ethernet/intel/ice/ice_txrx.c | 19 +- drivers/net/ethernet/intel/ice/ice_txrx.h | 29 +- drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 343 ++++++++++++--- drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 18 +- drivers/net/ethernet/intel/ice/ice_xsk.c | 26 +- drivers/net/veth.c | 42 ++ include/linux/if_vlan.h | 4 +- include/linux/skbuff.h | 13 +- include/net/xdp.h | 29 +- kernel/bpf/offload.c | 4 + net/core/xdp.c | 57 +++ .../selftests/bpf/prog_tests/xdp_metadata.c | 187 ++++---- .../selftests/bpf/progs/xdp_hw_metadata.c | 48 +- .../selftests/bpf/progs/xdp_metadata.c | 16 + tools/testing/selftests/bpf/testing_helpers.h | 3 + tools/testing/selftests/bpf/xdp_hw_metadata.c | 67 ++- tools/testing/selftests/bpf/xdp_metadata.h | 42 +- 25 files changed, 995 insertions(+), 446 deletions(-) -- 2.41.0