From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by mail.toke.dk (Postfix) with ESMTPS id 215AFA1C0D5 for ; Tue, 25 Jul 2023 23:28:15 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YVe5VQBt Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 055DA6189B; Tue, 25 Jul 2023 21:28:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB03C433C7; Tue, 25 Jul 2023 21:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690320493; bh=MlVasKHUR67c8YAUaXJTiStk2sj8JIq65rkbxf8GQDs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YVe5VQBtbrwoSD8W5d5GkTH5OY7Q+4U285lD7Wx+E/a93wFdw9JV6cnK4RW2XskfX kubj3MFPvztw8G3FMQf7GwZ9Fdzsdyw3fei7b3L2vccVXaXAShDHm4JpUkn3bTY4pd iTMetUQ0PvpsK+u3Zt3rMI/9sZV7VsnaGVy/leWmr7VsduoPNIM/0hj8Ro2NUhhOpC SdL8EKXw/ZB9kRB3sDlOCtA97HP1gCG+JVeQF0rbR5OWtclUbk7HgN3+Gwg/oAsP9C 75vdOsOlU3pJZrCLFI/qfNF4Gj+QfI18G2pfTM7L8nnb0fHYRIoHKxnSfBJ5334G2b 3NloLyLtZP+UQ== Date: Tue, 25 Jul 2023 14:28:11 -0700 From: Jakub Kicinski To: Stanislav Fomichev Message-ID: <20230725142811.07f4faa2@kernel.org> In-Reply-To: References: <20230724235957.1953861-1-sdf@google.com> <20230724235957.1953861-3-sdf@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KPZ7PP46E4MHO55PKSDDKTZJPYA3RVR7 X-Message-ID-Hash: KPZ7PP46E4MHO55PKSDDKTZJPYA3RVR7 X-MailFrom: kuba@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Horman , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, toke@kernel.org, willemb@google.com, dsahern@kernel.org, magnus.karlsson@intel.com, bjorn@kernel.org, maciej.fijalkowski@intel.com, hawk@kernel.org, netdev@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [RFC net-next v4 2/8] xsk: add TX timestamp and TX checksum offload support List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 25 Jul 2023 13:30:58 -0700 Stanislav Fomichev wrote: > > I know that it isn't the practice in this file. > > but adding the following makes kernel-doc happier > > about NETDEV_XSK_FLAGS_MASK not being documented. > > > > /* private: */ > > This is autogenerated file :-( But I guess I can try to extend ynl > scripts to put this comment before the mask. Let me look into that... Yes, please! I think I even wrote a patch for it at some point... but then we realized that enums didn't support /* private: */. Commit e27cb89a22ada4 has added the support, so we can get back to getting the YNL changes in place.