From: Song Yoong Siang <yoong.siang.song@intel.com>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@google.com>,
Alexander Duyck <alexanderduyck@fb.com>,
Ong Boon Leong <boon.leong.ong@intel.com>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
xdp-hints@xdp-project.net,
Song Yoong Siang <yoong.siang.song@intel.com>
Subject: [xdp-hints] [PATCH net-next 1/4] net: stmmac: restructure Rx hardware timestamping function
Date: Mon, 10 Apr 2023 18:09:36 +0800 [thread overview]
Message-ID: <20230410100939.331833-2-yoong.siang.song@intel.com> (raw)
In-Reply-To: <20230410100939.331833-1-yoong.siang.song@intel.com>
From: Ong Boon Leong <boon.leong.ong@intel.com>
Rearrange the function of getting Rx hardware timestamp for skb so
that it can be reused for XDP later.
Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: Song Yoong Siang <yoong.siang.song@intel.com>
---
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 21 ++++++++++++-------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 04fbb7770618..2cc6237a9c28 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -570,15 +570,14 @@ static void stmmac_get_tx_hwtstamp(struct stmmac_priv *priv,
* @priv: driver private structure
* @p : descriptor pointer
* @np : next descriptor pointer
- * @skb : the socket buffer
+ * @hwtstamp : hardware timestamp
* Description :
* This function will read received packet's timestamp from the descriptor
* and pass it to stack. It also perform some sanity checks.
*/
static void stmmac_get_rx_hwtstamp(struct stmmac_priv *priv, struct dma_desc *p,
- struct dma_desc *np, struct sk_buff *skb)
+ struct dma_desc *np, ktime_t *hwtstamp)
{
- struct skb_shared_hwtstamps *shhwtstamp = NULL;
struct dma_desc *desc = p;
u64 ns = 0;
@@ -595,9 +594,7 @@ static void stmmac_get_rx_hwtstamp(struct stmmac_priv *priv, struct dma_desc *p,
ns -= priv->plat->cdc_error_adj;
netdev_dbg(priv->dev, "get valid RX hw timestamp %llu\n", ns);
- shhwtstamp = skb_hwtstamps(skb);
- memset(shhwtstamp, 0, sizeof(struct skb_shared_hwtstamps));
- shhwtstamp->hwtstamp = ns_to_ktime(ns);
+ *hwtstamp = ns_to_ktime(ns);
} else {
netdev_dbg(priv->dev, "cannot get RX hw timestamp\n");
}
@@ -4909,6 +4906,7 @@ static void stmmac_dispatch_skb_zc(struct stmmac_priv *priv, u32 queue,
struct xdp_buff *xdp)
{
struct stmmac_channel *ch = &priv->channel[queue];
+ struct skb_shared_hwtstamps *shhwtstamp = NULL;
unsigned int len = xdp->data_end - xdp->data;
enum pkt_hash_types hash_type;
int coe = priv->hw->rx_csum;
@@ -4921,7 +4919,10 @@ static void stmmac_dispatch_skb_zc(struct stmmac_priv *priv, u32 queue,
return;
}
- stmmac_get_rx_hwtstamp(priv, p, np, skb);
+ shhwtstamp = skb_hwtstamps(skb);
+ memset(shhwtstamp, 0, sizeof(struct skb_shared_hwtstamps));
+ stmmac_get_rx_hwtstamp(priv, p, np, &shhwtstamp->hwtstamp);
+
stmmac_rx_vlan(priv->dev, skb);
skb->protocol = eth_type_trans(skb, priv->dev);
@@ -5213,6 +5214,7 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
rx_q->dma_rx_phy, desc_size);
}
while (count < limit) {
+ struct skb_shared_hwtstamps *shhwtstamp = NULL;
unsigned int buf1_len = 0, buf2_len = 0;
enum pkt_hash_types hash_type;
struct stmmac_rx_buffer *buf;
@@ -5407,7 +5409,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
/* Got entire packet into SKB. Finish it. */
- stmmac_get_rx_hwtstamp(priv, p, np, skb);
+ shhwtstamp = skb_hwtstamps(skb);
+ memset(shhwtstamp, 0, sizeof(struct skb_shared_hwtstamps));
+ stmmac_get_rx_hwtstamp(priv, p, np, &shhwtstamp->hwtstamp);
+
stmmac_rx_vlan(priv->dev, skb);
skb->protocol = eth_type_trans(skb, priv->dev);
--
2.34.1
next prev parent reply other threads:[~2023-04-10 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 10:09 [xdp-hints] [PATCH net-next 0/4] XDP Rx HWTS metadata for stmmac driver Song Yoong Siang
2023-04-10 10:09 ` Song Yoong Siang [this message]
2023-04-10 10:09 ` [xdp-hints] [PATCH net-next 2/4] net: stmmac: introduce wrapper for struct xdp_buff Song Yoong Siang
2023-04-10 10:09 ` [xdp-hints] [PATCH net-next 3/4] net: stmmac: add Rx HWTS metadata to XDP receive pkt Song Yoong Siang
2023-04-10 14:13 ` [xdp-hints] " Simon Horman
2023-04-10 15:33 ` Song, Yoong Siang
2023-04-10 18:11 ` Simon Horman
2023-04-10 16:25 ` Stanislav Fomichev
2023-04-12 1:31 ` Song, Yoong Siang
2023-04-12 4:00 ` Song, Yoong Siang
2023-04-10 10:09 ` [xdp-hints] [PATCH net-next 4/4] net: stmmac: add Rx HWTS metadata to XDP ZC " Song Yoong Siang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410100939.331833-2-yoong.siang.song@intel.com \
--to=yoong.siang.song@intel.com \
--cc=alexanderduyck@fb.com \
--cc=alexandre.torgue@foss.st.com \
--cc=ast@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=sdf@google.com \
--cc=xdp-hints@xdp-project.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox