From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by mail.toke.dk (Postfix) with ESMTPS id 0B7599E053F for ; Thu, 19 Jan 2023 23:15:50 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=Ksz0kEMc Received: by mail-pf1-x449.google.com with SMTP id f22-20020a056a00239600b0058d956679f5so1506148pfc.5 for ; Thu, 19 Jan 2023 14:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EUVmBv6n1yWhw6xb7kdgIkQjazkcMJ0jEx+B+OPrm+s=; b=Ksz0kEMcH940hdwk/Ayvr3beOSD13KPAZuFiwab9mSkUUfoYDEQtzZ2LzAWZsU4Z/v UK3zUnyqTf+GfEUDwLP7h7Sg5WsWJH3QOZguFgOLqHAWLHFoFL945LU2RxQ7nij3yiCw gC4ZGjyVp06xNd2n4mXY8BaCpupr/b5U30gKqHR4aJTwuWrHSVb7Q/Utt789EJZgswFb bW8J8hhSHF03x9kcDuNi+jiCLsnIYTrRAr4+RZ2kwvEyQqwsTtxxgbLdk5fl+pbSPksq BAB7k4SKUgTMOaI/km53xAQSWMdmHxCf3w4QHD3N/r0fcYuEQ47Nl09cfU7o8dO6auDW MOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EUVmBv6n1yWhw6xb7kdgIkQjazkcMJ0jEx+B+OPrm+s=; b=atSHLT1Sdgx3b21Nn/nPFuRF/VEsMjfDVhYX0tAQH8BUfCNdnZP+UrCKjtHlZxbdl9 Ig6TALDtTEveyaZzBCl9wh2YF/ZKNNk2qRcURiftd40lx5CgtRyU8ITZiQcIxAvkeVeV fv0yyW9IZOBg0gkP/lPPV8XDCcZIXThb2evZSd3mYTKOAmiaZQZxPppxaMu8jGLlVtvB 76j6rVSDL3OKT3vazVNvizdlVbK7l5j8H/jVdvbahmJGBeFgl9aJ/CSYeT6DL3vOa28U 1qmF6zdKg7lQdSJYzj7QVUQsTtz3440/FUSiQVmNUq79DR/qQUwT8owrbGQedVXolEFC Mirw== X-Gm-Message-State: AFqh2kqWQV3n1F6ldnC0SrYX5KpmwNFnj4nBljd4GO2t1Wl3HkNqnQuY 1oo52JyQTb8lGbvPaE4MryJP234= X-Google-Smtp-Source: AMrXdXtYG6XYudga/1qUvayFl3zZELMUnbf9QFMDzEfZUKXolfRrcqc9wXwoWaJ0lM7SXkO9RZwcut8= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a17:903:2350:b0:192:b09c:e066 with SMTP id c16-20020a170903235000b00192b09ce066mr1219079plh.2.1674166548372; Thu, 19 Jan 2023 14:15:48 -0800 (PST) Date: Thu, 19 Jan 2023 14:15:25 -0800 In-Reply-To: <20230119221536.3349901-1-sdf@google.com> Mime-Version: 1.0 References: <20230119221536.3349901-1-sdf@google.com> X-Mailer: git-send-email 2.39.0.246.g2a6d74b583-goog Message-ID: <20230119221536.3349901-7-sdf@google.com> From: Stanislav Fomichev To: bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: Z4V66POMHR6DDCHYJOFQDB2D6RLVFXR3 X-Message-ID-Hash: Z4V66POMHR6DDCHYJOFQDB2D6RLVFXR3 X-MailFrom: 3FMHJYwMKCeEVGIJRRJOH.FRPaGS-KLQWVaGS-SURMHFW.QHW@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] [PATCH bpf-next v8 06/17] selftests/bpf: Update expected test_offload.py messages List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Generic check has a different error message, update the selftest. Cc: John Fastabend Cc: David Ahern Cc: Martin KaFai Lau Cc: Jakub Kicinski Cc: Willem de Bruijn Cc: Jesper Dangaard Brouer Cc: Anatoly Burakov Cc: Alexander Lobakin Cc: Magnus Karlsson Cc: Maryam Tahhan Cc: xdp-hints@xdp-project.net Cc: netdev@vger.kernel.org Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_offload.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testing/selftests/bpf/test_offload.py index 7cb1bc05e5cf..40cba8d368d9 100755 --- a/tools/testing/selftests/bpf/test_offload.py +++ b/tools/testing/selftests/bpf/test_offload.py @@ -1039,7 +1039,7 @@ netns = [] offload = bpf_pinned("/sys/fs/bpf/offload") ret, _, err = sim.set_xdp(offload, "drv", fail=False, include_stderr=True) fail(ret == 0, "attached offloaded XDP program to drv") - check_extack(err, "Using device-bound program without HW_MODE flag is not supported.", args) + check_extack(err, "Using offloaded program without HW_MODE flag is not supported.", args) rm("/sys/fs/bpf/offload") sim.wait_for_flush() @@ -1088,12 +1088,12 @@ netns = [] ret, _, err = sim.set_xdp(pinned, "offload", fail=False, include_stderr=True) fail(ret == 0, "Pinned program loaded for a different device accepted") - check_extack_nsim(err, "program bound to different dev.", args) + check_extack(err, "Program bound to different device.", args) simdev2.remove() ret, _, err = sim.set_xdp(pinned, "offload", fail=False, include_stderr=True) fail(ret == 0, "Pinned program loaded for a removed device accepted") - check_extack_nsim(err, "xdpoffload of non-bound program.", args) + check_extack(err, "Program bound to different device.", args) rm(pin_file) bpftool_prog_list_wait(expected=0) @@ -1334,12 +1334,12 @@ netns = [] ret, _, err = simA.set_xdp(progB, "offload", force=True, JSON=False, fail=False, include_stderr=True) fail(ret == 0, "cross-ASIC program allowed") - check_extack_nsim(err, "program bound to different dev.", args) + check_extack(err, "Program bound to different device.", args) for d in simdevB.nsims: ret, _, err = d.set_xdp(progA, "offload", force=True, JSON=False, fail=False, include_stderr=True) fail(ret == 0, "cross-ASIC program allowed") - check_extack_nsim(err, "program bound to different dev.", args) + check_extack(err, "Program bound to different device.", args) start_test("Test multi-dev ASIC cross-dev map reuse...") -- 2.39.0.246.g2a6d74b583-goog