From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by mail.toke.dk (Postfix) with ESMTPS id 0883A9DC67F for ; Thu, 12 Jan 2023 01:32:50 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=P9IA7Bc5 Received: by mail-pj1-x104a.google.com with SMTP id h1-20020a17090a470100b0022646263abfso7305295pjg.6 for ; Wed, 11 Jan 2023 16:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wY4CHm/dlhkH6JmCucO1BIsfy2wsh3G3c7i4tQSl6Xk=; b=P9IA7Bc5KKc++o5Hh81jdspoLBd8DPfj1AoKUrzblpT9ar9j1uHq6Y2hazrnOD+JXP tHDyq1QWQddo0ncPP5lVq7zoD9sX5k+UDCdCipk0K8NHB4QLY998POL/8FHZpuRNiefw nGO+F5em9GlJ5NGS5hzIIpXUnSDRITXpQ+TV8pZFy1IufChev6g87DdkuRF+vSRqS4x+ dGj/LMOaSZER/dhcyfcKfJvp/dTIwC0CAAYWtd2z3Q/KpS3npODAsLWeU+Ti+kOL+6mj aKYqzeNMtXy5Iph6MyD9Dy1z7ZZcFSvIsyEMiZpR/KBGH6/3D6OFTmnDvgYi4wzil6MT 9KuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wY4CHm/dlhkH6JmCucO1BIsfy2wsh3G3c7i4tQSl6Xk=; b=JEC7bnnYz6fK+nD1Tubx5zHCyTBJa+WRX/BjAX4I7RCobkQgzLOka9dOEZUdutUOxx GVQEA94HLzo4F/vHzuuXIfErcSWLRCayFpkQYRt53PGPdWeC7Kei3zMmWXhON7IP8t1Y o/IxsF2mLgdCnaulqvPB+edSpdsU0vY4/FY1VWK/uH86QpoAXJQlX8dQASV2qGNF2fi8 7Ed1Z2p+4+23oOX+9BfySZeen07lkBQ0PNn7lerH2uKwsFHTrCVH6TtL2E/WuPUKD4UB /AHOcZu7WG4RJiZctsejavL2TfXbNqpyoiK79/p3+Tgv0TLC4J3sISg/zHdp/8VU69PD wnKQ== X-Gm-Message-State: AFqh2krYU7uW00lxsVQ23o+xUhzyJzP+rkAmrpbUUKNuYOrUWZo/h4+I Ko+/bvELeaTl61SCjTrB5c5bUpY= X-Google-Smtp-Source: AMrXdXvI01HYMbNdKc3+TR9flzcwjmAQ+GQN/sDzsCUe+1dijSVmU5PdWH9v8/SPAjdEue1oYa7SpWQ= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a17:90a:d0c1:b0:219:65c0:619f with SMTP id y1-20020a17090ad0c100b0021965c0619fmr6911930pjw.150.1673483568580; Wed, 11 Jan 2023 16:32:48 -0800 (PST) Date: Wed, 11 Jan 2023 16:32:23 -0800 In-Reply-To: <20230112003230.3779451-1-sdf@google.com> Mime-Version: 1.0 References: <20230112003230.3779451-1-sdf@google.com> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Message-ID: <20230112003230.3779451-11-sdf@google.com> From: Stanislav Fomichev To: bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID-Hash: 4ONNM53DLUB6H2YY2XFL6LX3YT2W4PAW X-Message-ID-Hash: 4ONNM53DLUB6H2YY2XFL6LX3YT2W4PAW X-MailFrom: 3MFW_YwMKCfsvgijrrjoh.frp0gs-klqwv0gs-surmhfw.qhw@flex--sdf.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, David Ahern , Jakub Kicinski , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] [PATCH bpf-next v7 10/17] veth: Support RX XDP metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The goal is to enable end-to-end testing of the metadata for AF_XDP. Cc: John Fastabend Cc: David Ahern Cc: Martin KaFai Lau Cc: Jakub Kicinski Cc: Willem de Bruijn Cc: Jesper Dangaard Brouer Cc: Anatoly Burakov Cc: Alexander Lobakin Cc: Magnus Karlsson Cc: Maryam Tahhan Cc: xdp-hints@xdp-project.net Cc: netdev@vger.kernel.org Signed-off-by: Stanislav Fomichev --- drivers/net/veth.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 70f50602287a..ba3e05832843 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -118,6 +118,7 @@ static struct { struct veth_xdp_buff { struct xdp_buff xdp; + struct sk_buff *skb; }; static int veth_get_link_ksettings(struct net_device *dev, @@ -602,6 +603,7 @@ static struct xdp_frame *veth_xdp_rcv_one(struct veth_rq *rq, xdp_convert_frame_to_buff(frame, xdp); xdp->rxq = &rq->xdp_rxq; + vxbuf.skb = NULL; act = bpf_prog_run_xdp(xdp_prog, xdp); @@ -823,6 +825,7 @@ static struct sk_buff *veth_xdp_rcv_skb(struct veth_rq *rq, __skb_push(skb, skb->data - skb_mac_header(skb)); if (veth_convert_skb_to_xdp_buff(rq, xdp, &skb)) goto drop; + vxbuf.skb = skb; orig_data = xdp->data; orig_data_end = xdp->data_end; @@ -1602,6 +1605,28 @@ static int veth_xdp(struct net_device *dev, struct netdev_bpf *xdp) } } +static int veth_xdp_rx_timestamp(const struct xdp_md *ctx, u64 *timestamp) +{ + struct veth_xdp_buff *_ctx = (void *)ctx; + + if (!_ctx->skb) + return -EOPNOTSUPP; + + *timestamp = skb_hwtstamps(_ctx->skb)->hwtstamp; + return 0; +} + +static int veth_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash) +{ + struct veth_xdp_buff *_ctx = (void *)ctx; + + if (!_ctx->skb) + return -EOPNOTSUPP; + + *hash = skb_get_hash(_ctx->skb); + return 0; +} + static const struct net_device_ops veth_netdev_ops = { .ndo_init = veth_dev_init, .ndo_open = veth_open, @@ -1623,6 +1648,11 @@ static const struct net_device_ops veth_netdev_ops = { .ndo_get_peer_dev = veth_peer_dev, }; +static const struct xdp_metadata_ops veth_xdp_metadata_ops = { + .xmo_rx_timestamp = veth_xdp_rx_timestamp, + .xmo_rx_hash = veth_xdp_rx_hash, +}; + #define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HW_CSUM | \ NETIF_F_RXCSUM | NETIF_F_SCTP_CRC | NETIF_F_HIGHDMA | \ NETIF_F_GSO_SOFTWARE | NETIF_F_GSO_ENCAP_ALL | \ @@ -1639,6 +1669,7 @@ static void veth_setup(struct net_device *dev) dev->priv_flags |= IFF_PHONY_HEADROOM; dev->netdev_ops = &veth_netdev_ops; + dev->xdp_metadata_ops = &veth_xdp_metadata_ops; dev->ethtool_ops = &veth_ethtool_ops; dev->features |= NETIF_F_LLTX; dev->features |= VETH_FEATURES; -- 2.39.0.314.g84b9a713c41-goog