From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1])
	by mail.toke.dk (Postfix) with ESMTPS id 82A329CDCF4
	for <xdp-hints@xdp-project.net>; Fri,  9 Dec 2022 23:13:12 +0100 (CET)
Authentication-Results: mail.toke.dk;
	dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=JSJHBySS
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by sin.source.kernel.org (Postfix) with ESMTPS id 13247CE2A59;
	Fri,  9 Dec 2022 22:13:07 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EA98C433EF;
	Fri,  9 Dec 2022 22:13:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1670623985;
	bh=sWo6QnyRrnLIciflYfJb5Tz38EgC8oSkiMy96ny7pcs=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=JSJHBySSzQ7T/hhs06GIPYb2UxXmBePu9fG+WH7kkKPcYdvMLY15ODdYIu4vPzzoo
	 KdXPUVyHw6aRk+nmjn49CmjEgiW5U0gRvYSucuKUwrYJkA8L7c9pOaviuMxMb/WcGt
	 eaofScKt4Szz8P0FNCckGKKynnckllfXZxvTNELVUYBrno/5n5mp+v1HEvdOXoAAje
	 7knzUf1UYQhNSWwo3adiMqtj/9xe0E+u5DdrKyPPTTjfpl9+PvM+h5bxrb4Gm+3vs2
	 admm1EqnheyETz9CsG9Y0gi+LAo5uZ8AMXC3qrgYiR6x6wyhy5OD3fM7Vm8j8yOFnE
	 jJsuimYq9nkXA==
Date: Fri, 9 Dec 2022 14:13:03 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@google.com>
Message-ID: <20221209141303.3c3bbb7b@kernel.org>
In-Reply-To: <CAKH8qBsx4pPuvYenpM18NgdnGCG8QjqnsNY40Uc44EXTUVabMA@mail.gmail.com>
References: <20221206024554.3826186-1-sdf@google.com>
	<20221206024554.3826186-12-sdf@google.com>
	<875yellcx6.fsf@toke.dk>
	<CAKH8qBv7nWdknuf3ap_ekpAhMgvtmoJhZ3-HRuL8Wv70SBWMSQ@mail.gmail.com>
	<87359pl9zy.fsf@toke.dk>
	<CAADnVQ+=71Y+ypQTOgFTJWY7w3YOUdY39is4vpo3aou11=eMmw@mail.gmail.com>
	<87tu25ju77.fsf@toke.dk>
	<CAADnVQ+MyE280Q-7iw2Y-P6qGs4xcDML-tUrXEv_EQTmeESVaQ@mail.gmail.com>
	<87o7sdjt20.fsf@toke.dk>
	<CAKH8qBswBu7QAWySWOYK4X41mwpdBj0z=6A9WBHjVYQFq9Pzjw@mail.gmail.com>
	<87cz8sk59e.fsf@toke.dk>
	<20221209084524.01c09d9c@kernel.org>
	<CAKH8qBsx4pPuvYenpM18NgdnGCG8QjqnsNY40Uc44EXTUVabMA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-ID-Hash: IB7QPTOIJM5GXC4JHW26JKWHIJHSFETL
X-Message-ID-Hash: IB7QPTOIJM5GXC4JHW26JKWHIJHSFETL
X-MailFrom: kuba@kernel.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@redhat.com>, Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Saeed Mahameed <saeedm@nvidia.com>, David Ahern <dsahern@gmail.com>, Willem de Bruijn <willemb@google.com>, Jesper Dangaard Brouer <brouer@redhat.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Alexander Lobakin <alexandr.lobakin@intel.com>, Magnus Karlsson <magnus.karlsson@gmail.com>, Maryam Tahhan <mtahhan@redhat.com>, xdp-hints@xdp-project.net, Network Development <netdev@vger.kernel.org>
X-Mailman-Version: 3.3.7
Precedence: list
Subject: [xdp-hints] Re: [PATCH bpf-next v3 11/12] mlx5: Support RX XDP metadata
List-Id: XDP hardware hints design discussion <xdp-hints.xdp-project.net>
Archived-At: <https://lists.xdp-project.net/xdp-hints/20221209141303.3c3bbb7b@kernel.org/>
List-Archive: <https://lists.xdp-project.net/xdp-hints/>
List-Help: <mailto:xdp-hints-request@xdp-project.net?subject=help>
List-Owner: <mailto:xdp-hints-owner@xdp-project.net>
List-Post: <mailto:xdp-hints@xdp-project.net>
List-Subscribe: <mailto:xdp-hints-join@xdp-project.net>
List-Unsubscribe: <mailto:xdp-hints-leave@xdp-project.net>

On Fri, 9 Dec 2022 09:46:20 -0800 Stanislav Fomichev wrote:
> > Is partial inlining hard? (inline just the check and generate a full
> > call for the read, ending up with the same code as with _supported())  
> 
> I'm assuming you're suggesting to do this partial inlining manually
> (as in, writing the code to output this bytecode)?
> This probably also falls into the "manual bpf asm generation tech debt" bucket?
> LMK if I missed your point.

Maybe just ignore that, I'm not sure how the unrolling of 
the _supported() calls was expected to work in the first place.