From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by mail.toke.dk (Postfix) with ESMTPS id 9E4419CCB38 for ; Thu, 8 Dec 2022 05:26:05 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Xw8F6uVj Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55EC761BBE; Thu, 8 Dec 2022 04:26:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCDD2C433D6; Thu, 8 Dec 2022 04:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670473561; bh=pN+wGVc+4cW/yHQxiTF6zQ8V1EauH9TedbOtylafW/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xw8F6uVjzfJiIWtPGl//KuiDk0NqwqZpU03E12FkNIQIM3SzfysGj+oWk2nQQFYZV sWmv9wWq1DMiUmgzKcm3ejtvVHpouGCIAxBzobzQAtlBGTVrSsM/lZrr79Pey+N3cY zsS5xKbzVWJLKaBYYQk62CydY3YsD3wtPP2CLQvUyiNvdCoACfVimlCJpj65Is6sTf QSA/NGDPp44x3z+lwnOeDnqKDqbW2N1QLwEfevfBekAIaIsDe5j5lByCq+pZGP8rG5 hbUK5ybG3zodeFWaQmH614T+53DQZi0w/nTh3rrbkkDumccNlEfJCUe8di4m5qO+i0 zHgkz/wDjwAmg== Date: Wed, 7 Dec 2022 20:25:59 -0800 From: Jakub Kicinski To: Stanislav Fomichev Message-ID: <20221207202559.4d507ccf@kernel.org> In-Reply-To: <20221206024554.3826186-2-sdf@google.com> References: <20221206024554.3826186-1-sdf@google.com> <20221206024554.3826186-2-sdf@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: I5OTWBXNSONHZKMQTJ5XOT7VKQDSYNZ2 X-Message-ID-Hash: I5OTWBXNSONHZKMQTJ5XOT7VKQDSYNZ2 X-MailFrom: kuba@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern , Willem de Bruijn , Jesper Dangaard Brouer , Anatoly Burakov , Alexander Lobakin , Magnus Karlsson , Maryam Tahhan , xdp-hints@xdp-project.net, netdev@vger.kernel.org X-Mailman-Version: 3.3.7 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next v3 01/12] bpf: Document XDP RX metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 5 Dec 2022 18:45:43 -0800 Stanislav Fomichev wrote: > +- ``bpf_xdp_metadata_rx_timestamp_supported`` returns true/false to > + indicate whether the device supports RX timestamps > +- ``bpf_xdp_metadata_rx_timestamp`` returns packet RX timestamp > +- ``bpf_xdp_metadata_rx_hash_supported`` returns true/false to > + indicate whether the device supports RX hash > +- ``bpf_xdp_metadata_rx_hash`` returns packet RX hash Would you mind pointing to the discussion about the separate _supported() kfuncs? I recall folks had concerns about the function call overhead, and now we have 2 calls per field? :S