From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
	by mail.toke.dk (Postfix) with ESMTPS id 72BD49C52F7
	for <xdp-hints@xdp-project.net>; Wed, 23 Nov 2022 20:17:17 +0100 (CET)
Authentication-Results: mail.toke.dk;
	dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WVEWPdZR
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 469AC61EC6;
	Wed, 23 Nov 2022 19:17:14 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06FEBC433D6;
	Wed, 23 Nov 2022 19:17:12 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1669231033;
	bh=RdOWIKFgH2np1ctDV/eZoQ+NtT5Cm6zsg4hnh0svOto=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=WVEWPdZR8K0svlzOZbXCh/Y1XOO16xVJL2NPgX/6EOSQQ5iHwkS0oouOF80dS2c64
	 IMKOlrE8WEvM1zlADtaHBsJjFepLxg8kyXFSaodXu3mqAGvO9wPG+Zo26uCQzsAcJX
	 apQu3tUvqIf+vwkRNIM/bJgChEM2h8DaXJDPaOx5aq+t3wd2VPQE/HDbRBJGvtTk6H
	 jfh5Fn/F8xpr1zXmHTtobRsM0oKo8ib51cD4IsRuymzy6vCogkyrNuV3FP1oXJhpSP
	 U2Erw9AU/fcNTu+VR6uzQ0qRyDQQ+ZYiAsPyy1GmKaIT5FT7cytQod8pZwGIzRzNc9
	 HU5GY0Z4R4MEg==
Date: Wed, 23 Nov 2022 11:17:12 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@google.com>
Message-ID: <20221123111712.1da24f54@kernel.org>
In-Reply-To: <CAKH8qBsSFg+3ULN-+aqabXZJRVwPtq9P71d0VZCuT2tMrx4DHw@mail.gmail.com>
References: <20221121182552.2152891-1-sdf@google.com>
	<20221121182552.2152891-9-sdf@google.com>
	<877czlvj9x.fsf@toke.dk>
	<CAKH8qBsSFg+3ULN-+aqabXZJRVwPtq9P71d0VZCuT2tMrx4DHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-ID-Hash: QFUEIUCXHSZPYYVGNXWQAG3PDYBFCLE5
X-Message-ID-Hash: QFUEIUCXHSZPYYVGNXWQAG3PDYBFCLE5
X-MailFrom: kuba@kernel.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= <toke@redhat.com>, bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, David Ahern <dsahern@gmail.com>, Willem de Bruijn <willemb@google.com>, Jesper Dangaard Brouer <brouer@redhat.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Alexander Lobakin <alexandr.lobakin@intel.com>, Magnus Karlsson <magnus.karlsson@gmail.com>, Maryam Tahhan <mtahhan@redhat.com>, xdp-hints@xdp-project.net, netdev@vger.kernel.org
X-Mailman-Version: 3.3.7
Precedence: list
Subject: [xdp-hints] Re: [PATCH bpf-next v2 8/8] selftests/bpf: Simple program to dump XDP RX metadata
List-Id: XDP hardware hints design discussion <xdp-hints.xdp-project.net>
Archived-At: <https://lists.xdp-project.net/xdp-hints/20221123111712.1da24f54@kernel.org/>
List-Archive: <https://lists.xdp-project.net/xdp-hints/>
List-Help: <mailto:xdp-hints-request@xdp-project.net?subject=help>
List-Owner: <mailto:xdp-hints-owner@xdp-project.net>
List-Post: <mailto:xdp-hints@xdp-project.net>
List-Subscribe: <mailto:xdp-hints-join@xdp-project.net>
List-Unsubscribe: <mailto:xdp-hints-leave@xdp-project.net>

On Wed, 23 Nov 2022 10:29:23 -0800 Stanislav Fomichev wrote:
> > return ch.rx_count ?: ch.combined_count;
> >
> > works though :)  
> 
> Perfect, will do the same :-) Thank you for running and testing!

The correct value is ch.rx_count + ch.combined_count

We've been over this many times, I thought it was coded up in libbpf
but I don't see it now :S