From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mail.toke.dk (Postfix) with ESMTPS id C872898590A for ; Tue, 5 Jul 2022 16:39:24 +0200 (CEST) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=fnxTLeiy DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657031966; x=1688567966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bwCbUaDqvMtVlN4ueDxGSnxY6sfa6e9kx0utA3eoaAw=; b=fnxTLeiydMJqkoA3ykCS7yqB3eo/SdPTcgJtZiXDsVHESkcniSkRMEY3 8cZORg635zA99glpBiNNdw+WK77rHQWlPElHggLLYrw9gxatz5CAUEiZ7 0joZrkhZgIWMWWvoPx1MLrbtfi+GnPuj7nooHCv9z6K4dFslr0d6C1kni Dcp+Z0X2NRHPNT4W3RcstUz+teTtrgkCP0x7X0plXt41dsPqxnQzTn73O WNB4hs11y6Z1jrSEMEvqWsYzBqu5MyHlDnCsk9qbwavkkxbn3fKeVHubR EWYODMdJ2aBKHFnkKwND9ToSc0VvVnYr/l4gVpDvNE7TzBrAH415zXsHU Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10398"; a="263792386" X-IronPort-AV: E=Sophos;i="5.92,247,1650956400"; d="scan'208";a="263792386" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 07:39:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,247,1650956400"; d="scan'208";a="839142776" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by fmsmga006.fm.intel.com with ESMTP; 05 Jul 2022 07:39:08 -0700 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 265Ed6BM016910; Tue, 5 Jul 2022 15:39:06 +0100 From: Alexander Lobakin To: Jesper Dangaard Brouer Date: Tue, 5 Jul 2022 16:38:38 +0200 Message-Id: <20220705143838.19500-1-alexandr.lobakin@intel.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <0cd3fd67-e179-7c27-a74f-255a05359941@redhat.com> References: <20220628194812.1453059-1-alexandr.lobakin@intel.com> <62bbedf07f44a_2181420830@john.notmuch> <87iloja8ly.fsf@toke.dk> <20220704154440.7567-1-alexandr.lobakin@intel.com> <0cd3fd67-e179-7c27-a74f-255a05359941@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: P32ADFA6DRJ24WGPOYJCEKDRPFVZVZXO X-Message-ID-Hash: P32ADFA6DRJ24WGPOYJCEKDRPFVZVZXO X-MailFrom: alexandr.lobakin@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alexander Lobakin , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , brouer@redhat.com, John Fastabend , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Larysa Zaremba , Michal Swiatkowski , Jesper Dangaard Brouer , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Yajun Deng , Willem de Bruijn , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.5 Precedence: list Subject: [xdp-hints] Re: [PATCH RFC bpf-next 00/52] bpf, xdp: introduce and use Generic Hints/metadata List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jesper Dangaard Brouer Date: Mon, 4 Jul 2022 19:13:53 +0200 > On 04/07/2022 17.44, Alexander Lobakin wrote: > >> Agreed. This incremental approach is basically what Jesper's > >> simultaneous series makes a start on, AFAICT? Would be nice if y'all > >> could converge the efforts :) > > > I don't know why at some point Jesper decided to go on his own as he > > for sure was using our tree as a base for some time, dunno what > > happened then. Regarding these two particular submissions, I didn't > > see Jesper's RFC when sending mine, only after when I went to read > > some stuff. > > > > Well, I have written to you (offlist) that the git tree didn't compile, > so I had a hard time getting it into a working state. We had a > ping-pong of stuff to fix, but it wasn't and you basically told me to > switch to using LLVM to compile your kernel tree, I was not interested > in doing that. Yes and no, I only told you that I missed those build issues due to that I use LLVM as my primary compiler, but I didn't suggest you switch to it. Then I fixed all of the issues in a couple days and wrote you the email on 3th of June saying that everything works now =\ > > I have looked at the code in your GitHub tree, and decided that it was > an over-engineered approach IMHO. Also simply being 52 commits deep > without having posted this incrementally upstream were also a > non-starter for me, as this isn't the way-to-work upstream. So Ingo announced recently that he has a series of 2300+ patches to try to fix include hell. Now he's preparing to submit them by batches/series. Look at this RFC as at an announce. "Hey folks, I have a bunch of stuff and will be submitting it soon, but I'm posting the whole changeset here, so you could take a look or give it a try before it's actually started being posted". All this is mentioned in the cover letter as well. What is the problem? Ok, next time I can not do any announces and just start posting series if it made such misunderstandings. Anyway, I will post a demo-version of the series in a couple weeks containing only the parts required to get Hints working on ice if folks prefer to look at the pencil draft instead of looking at the final painting (never thought I'll have to do that in the kernel dev community :D). > > To get the ball rolling, I have implemented the base XDP-hints support > here[1] with only 9 patches (including support for two drivers). > > IMHO we need to start out small and not intermix these huge refactoring > patches. E.g. I'm not convinced renaming net/{core/xdp.c => bpf/core.c} > is an improvement. Those cleanup patches can be easily put in a standalone series as a prerequisite. I even mentioned them in the cover letter. File names is a matter of discussing, my intention there was mainly to move XDP stuff out of overburdened net/core/dev.c. > > -Jesper > > [1] > https://lore.kernel.org/bpf/165643378969.449467.13237011812569188299.stgit@firesoul/ Thanks, Olek