From: Jesper Dangaard Brouer <brouer@redhat.com>
To: bpf@vger.kernel.org
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net,
alexandr.lobakin@intel.com, larysa.zaremba@intel.com,
xdp-hints@xdp-project.net, anthony.l.nguyen@intel.com,
yoong.siang.song@intel.com, boon.leong.ong@intel.com,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com,
john.fastabend@gmail.com, hawk@kernel.org, davem@davemloft.net
Subject: [xdp-hints] [PATCH bpf-next V3 3/6] selftests/bpf: xdp_hw_metadata RX hash return code info
Date: Wed, 22 Mar 2023 17:01:27 +0100 [thread overview]
Message-ID: <167950088752.2796265.16037961017301094426.stgit@firesoul> (raw)
In-Reply-To: <167950085059.2796265.16405349421776056766.stgit@firesoul>
When driver developers add XDP-hints kfuncs for RX hash it is
practical to print the return code in bpf_printk trace pipe log.
Print hash value as a hex value, both AF_XDP userspace and bpf_prog,
as this makes it easier to spot poor quality hashes.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Stanislav Fomichev <sdf@google.com>
---
.../testing/selftests/bpf/progs/xdp_hw_metadata.c | 9 ++++++---
tools/testing/selftests/bpf/xdp_hw_metadata.c | 5 ++++-
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
index 40c17adbf483..ce07010e4d48 100644
--- a/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
+++ b/tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
@@ -77,10 +77,13 @@ int rx(struct xdp_md *ctx)
meta->rx_timestamp = 0; /* Used by AF_XDP as not avail signal */
}
- if (!bpf_xdp_metadata_rx_hash(ctx, &meta->rx_hash))
- bpf_printk("populated rx_hash with %u", meta->rx_hash);
- else
+ ret = bpf_xdp_metadata_rx_hash(ctx, &meta->rx_hash);
+ if (ret >= 0) {
+ bpf_printk("populated rx_hash with 0x%08X", meta->rx_hash);
+ } else {
+ bpf_printk("rx_hash not-avail errno:%d", ret);
meta->rx_hash = 0; /* Used by AF_XDP as not avail signal */
+ }
return bpf_redirect_map(&xsk, ctx->rx_queue_index, XDP_PASS);
}
diff --git a/tools/testing/selftests/bpf/xdp_hw_metadata.c b/tools/testing/selftests/bpf/xdp_hw_metadata.c
index 400bfe19abfe..b7e39ff15788 100644
--- a/tools/testing/selftests/bpf/xdp_hw_metadata.c
+++ b/tools/testing/selftests/bpf/xdp_hw_metadata.c
@@ -3,6 +3,9 @@
/* Reference program for verifying XDP metadata on real HW. Functional test
* only, doesn't test the performance.
*
+ * BPF-prog bpf_printk info output can be access via
+ * /sys/kernel/debug/tracing/trace_pipe
+ *
* RX:
* - UDP 9091 packets are diverted into AF_XDP
* - Metadata verified:
@@ -156,7 +159,7 @@ static void verify_xdp_metadata(void *data, clockid_t clock_id)
meta = data - sizeof(*meta);
- printf("rx_hash: %u\n", meta->rx_hash);
+ printf("rx_hash: 0x%08X\n", meta->rx_hash);
printf("rx_timestamp: %llu (sec:%0.4f)\n", meta->rx_timestamp,
(double)meta->rx_timestamp / NANOSEC_PER_SEC);
if (meta->rx_timestamp) {
next prev parent reply other threads:[~2023-03-22 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 16:01 [xdp-hints] [PATCH bpf-next V3 0/6] XDP-hints kfuncs for Intel driver igc Jesper Dangaard Brouer
2023-03-22 16:01 ` [xdp-hints] [PATCH bpf-next V3 1/6] igc: enable and fix RX hash usage by netstack Jesper Dangaard Brouer
2023-04-12 11:38 ` [xdp-hints] " Song, Yoong Siang
2023-03-22 16:01 ` [xdp-hints] [PATCH bpf-next V3 2/6] selftests/bpf: xdp_hw_metadata track more timestamps Jesper Dangaard Brouer
2023-03-22 16:01 ` Jesper Dangaard Brouer [this message]
2023-03-22 16:09 ` [xdp-hints] Re: [PATCH bpf-next V3 3/6] selftests/bpf: xdp_hw_metadata RX hash return code info Alexei Starovoitov
2023-03-22 19:00 ` Stanislav Fomichev
2023-03-22 16:01 ` [xdp-hints] [PATCH bpf-next V3 4/6] igc: add igc_xdp_buff wrapper for xdp_buff in driver Jesper Dangaard Brouer
2023-03-22 16:01 ` [xdp-hints] [PATCH bpf-next V3 5/6] igc: add XDP hints kfuncs for RX timestamp Jesper Dangaard Brouer
2023-04-12 11:40 ` [xdp-hints] " Song, Yoong Siang
2023-04-12 15:37 ` Song, Yoong Siang
2023-03-22 16:01 ` [xdp-hints] [PATCH bpf-next V3 6/6] igc: add XDP hints kfuncs for RX hash Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.xdp-project.net/postorius/lists/xdp-hints.xdp-project.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167950088752.2796265.16037961017301094426.stgit@firesoul \
--to=brouer@redhat.com \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=xdp-hints@xdp-project.net \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox