From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mail.toke.dk (Postfix) with ESMTPS id 64FF69E6529 for ; Thu, 2 Feb 2023 00:50:19 +0100 (CET) Authentication-Results: mail.toke.dk; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bDf4qA4J Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1346461900; Wed, 1 Feb 2023 23:50:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 5ACF8C4339B; Wed, 1 Feb 2023 23:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675295417; bh=ZdgDvFkVnbmWnbwbWYR2gWCh8PAGZgIOoNtC+PHBQnE=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=bDf4qA4J6HGlnm+R7mCMtznGGTt/wumv7JHDQvJZ0o92vCJyXpke+Ue0M7umpgmbl zSUJm0uIc4T5/XwGWoeAjJG8htFvvx0aiKt39MWf4FAn52n30Q2oBsPaJAVYQWuSFm PgjhViRbPWoxGH68rOpxDXQBPFyOm4cEgvR7FJJupoOq6kkjKwwFPbSI1v6UiiIfp7 3dq/92bwKLlsOvmS7xHdtRHD6kErQQePSP9f4eHdnmo4yTur8Py/JbMfrGYARUE4o4 X2XlQZUCq3Adi+g7TGpwTx8OIzvn5QIPUNe4sQfc+o0gPkHCQtxIYEHyRA3vnLBG7f uyCrTrknz+HkQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 38884E21EEC; Wed, 1 Feb 2023 23:50:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: patchwork-bot+netdevbpf@kernel.org Message-Id: <167529541722.452.2094492229750071530.git-patchwork-notify@kernel.org> Date: Wed, 01 Feb 2023 23:50:17 +0000 References: <167527517464.938135.13750760520577765269.stgit@firesoul> In-Reply-To: <167527517464.938135.13750760520577765269.stgit@firesoul> To: Jesper Dangaard Brouer Message-ID-Hash: GLFGHT2RSNMP2HBPMMGAI4KHZCHUQGKN X-Message-ID-Hash: GLFGHT2RSNMP2HBPMMGAI4KHZCHUQGKN X-MailFrom: patchwork-bot+netdevbpf@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@vger.kernel.org, sdf@google.com, netdev@vger.kernel.org, martin.lau@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, john.fastabend@gmail.com, dsahern@gmail.com, willemb@google.com, void@manifault.com, kuba@kernel.org, xdp-hints@xdp-project.net X-Mailman-Version: 3.3.8 Precedence: list Subject: [xdp-hints] Re: [PATCH bpf-next V1] selftests/bpf: fix unmap bug in prog_tests/xdp_metadata.c List-Id: XDP hardware hints design discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann : On Wed, 01 Feb 2023 19:12:54 +0100 you wrote: > The function close_xsk() unmap via munmap() the wrong memory pointer. > > The call xsk_umem__delete(xsk->umem) have already freed xsk->umem. > Thus the call to munmap(xsk->umem, UMEM_SIZE) will have unpredictable > behavior that can lead to Segmentation fault elsewhere, as man page > explain subsequent references to these pages will generate SIGSEGV. > > [...] Here is the summary with links: - [bpf-next,V1] selftests/bpf: fix unmap bug in prog_tests/xdp_metadata.c https://git.kernel.org/bpf/bpf-next/c/f2922f77a6a6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html